Skip to content

Move JsonSchema behind a Cargo feature - #1446

Open
adamchalmers wants to merge 1 commit into
mainfrom
achalmers/conditional-json-schema
Open

adamchalmers wants to merge 1 commit into
mainfrom
achalmers/conditional-json-schema

Conversation

@adamchalmers

@adamchalmers adamchalmers commented Oct 13, 2026 •

Copy link
Copy Markdown
Collaborator

Deriving JsonSchema adds compilation time, and not every consumer of this library needs it.

Do not merge until I've got integration PRs open for this in kcl-lib.

@codecov

codecov Bot commented Oct 13, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (main@a71cf7d). Learn more about missing BASE report.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1446   +/-   ##
=======================================
  Coverage        ?   36.12%           
=======================================
  Files           ?       32           
  Lines           ?     1733           
  Branches        ?        0           
=======================================
  Hits            ?      626           
  Misses          ?     1107           
  Partials        ?        0           
Flag Coverage Δ
unittests 36.12% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants