Repository navigation
Add a STEP schema export option - #1428
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1428 +/- ##
=======================================
Coverage ? 36.11%
=======================================
Files ? 32
Lines ? 1736
Branches ? 0
=======================================
Hits ? 627
Misses ? 1109
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
adamchalmers
reviewed
Oct 7, 2026
| use crate::{coord, format::OutputFormat3d, shared::FileExportFormat, units::UnitLength}; | ||
|
|
||
| #[test] | ||
| fn schema_defaults_to_ap242() { |
Collaborator
There was a problem hiding this comment.
There's no need to test the Rust stdlib derive macros, if you put #[default] on something, it's safe to assume that's the default.
Contributor
There was a problem hiding this comment.
The same goes for testing (de)serialisation.
adamchalmers
approved these changes
Oct 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
schemato STEP export options withap203(edition 2),ap214, andap242. Omitted JSON, Rust defaults, and builders retain AP242.Validation: 17 API library tests, package Clippy, and formatting pass. Schema-aware export coverage is in format #918.
Consumed by format #917 and #918. Workspace lint CI currently fails in unchanged modeling-session examples on macro semicolons.