Repository navigation
Use CPU engines with graphics for all KCL execution - #1898
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1898 +/- ##
==========================================
+ Coverage 67.90% 67.92% +0.02%
==========================================
Files 43 43
Lines 8705 8718 +13
==========================================
+ Hits 5911 5922 +11
- Misses 2794 2796 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
bcorey
force-pushed
the
bcorey/geometry-only-exec
branch
from
October 16, 2026 21:00
94b73dc to
1b5020d
Compare
bcorey
force-pushed
the
bcorey/geometry-only-exec
branch
from
October 16, 2026 21:10
6c2792d to
8cae41a
Compare
jtran
approved these changes
Oct 16, 2026
Co-authored-by: Jonathan Tran <jonnytran@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All instances of ExecutorSettings in CLI are sourced from two helper methods, one for kcl commands and one for "copilot" commands. Made sure that the KCL helper always sets geo_only=true. the copilot/ZK helper has been left alone. Set the pool to "cpu" when geometry_only is true.
Because the CLI can execute arbitrary KCL and some KCL cannot run on an engine with no graphics context, I've enabled graphics for all KCL execution modes.
Tests have the same outcomes as on
main. That means all but 1 succeed when pointed at the dev environment, and all but 36 succeed when pointed at prod. Added clarification to the README on how to set the token and host for the test run.Mike's work to emulate graphics on the CPU engines made this a lot easier than it was going to be. But because the GLB-based CPU renderer is so handy for troubleshooting export issues, I will still be adding that as an alternative render option for KCL commands in an upcoming PR so file format team and others working on rendering can quickly get visual export quality feedback.