Skip to content

Use CPU engines with graphics for all KCL execution - #1898

Merged
bcorey merged 6 commits into
mainfrom
bcorey/geometry-only-exec
Oct 20, 2026
Merged

bcorey merged 6 commits into
mainfrom
bcorey/geometry-only-exec

Conversation

@bcorey

@bcorey bcorey commented Oct 8, 2026 •

Copy link
Copy Markdown
Contributor

All instances of ExecutorSettings in CLI are sourced from two helper methods, one for kcl commands and one for "copilot" commands. Made sure that the KCL helper always sets geo_only=true. the copilot/ZK helper has been left alone. Set the pool to "cpu" when geometry_only is true.

Because the CLI can execute arbitrary KCL and some KCL cannot run on an engine with no graphics context, I've enabled graphics for all KCL execution modes.

Tests have the same outcomes as on main. That means all but 1 succeed when pointed at the dev environment, and all but 36 succeed when pointed at prod. Added clarification to the README on how to set the token and host for the test run.

Mike's work to emulate graphics on the CPU engines made this a lot easier than it was going to be. But because the GLB-based CPU renderer is so handy for troubleshooting export issues, I will still be adding that as an alternative render option for KCL commands in an upcoming PR so file format team and others working on rendering can quickly get visual export quality feedback.

@codecov

codecov Bot commented Oct 8, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 63.15789% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 67.92%. Comparing base (2307f86) to head (db0eb7f).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
src/context.rs 58.82% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1898      +/-   ##
==========================================
+ Coverage   67.90%   67.92%   +0.02%     
==========================================
  Files          43       43              
  Lines        8705     8718      +13     
==========================================
+ Hits         5911     5922      +11     
- Misses       2794     2796       +2     
Flag Coverage Δ
unittests 67.92% <63.15%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@bcorey
bcorey force-pushed the bcorey/geometry-only-exec branch from 94b73dc to 1b5020d Compare October 16, 2026 21:00
@bcorey bcorey changed the title Set geometry_only=true for all instances of ExecutorSettings Use CPU engines with graphics for all KCL execution Oct 16, 2026
@bcorey
bcorey force-pushed the bcorey/geometry-only-exec branch from 6c2792d to 8cae41a Compare October 16, 2026 21:10
Comment thread README.md Outdated
Co-authored-by: Jonathan Tran <jonnytran@gmail.com>
@bcorey
bcorey merged commit 73815da into main Oct 20, 2026
25 checks passed
@bcorey
bcorey deleted the bcorey/geometry-only-exec branch October 20, 2026 03:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants