Repository navigation
Fix: the fields output by Using are not determined by JoinType - #401
Open
goransh-walia wants to merge 1 commit into
Open
goransh-walia wants to merge 1 commit into
goransh-walia wants to merge 1 commit into
Conversation
KKould
self-requested a review
November 11, 2026 11:05
Member
|
Thank you for your contribution; you can try running |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #205
What problem does this PR solve?
Issue link: #205
Columns output by
USINGwere previously determined byJoinType, causing incorrect expression evaluation and column hiding behavior in joins.What is changed and how it works?
UsingColumn::expr()insrc/binder/mod.rsto always generate aScalarExpression::Coalescecontaining both left and right column expressions typed withLogicalType::max_logical_type, rather than selecting expressions based onJoinType.UsingColumn::hides_column()to always hideright_columninstead of choosing betweenleft_columnandright_columnbased on whether the join was a right outer join.join_typeto_join_typeinUsingColumn.Code changes
Check List
Tests
Side effects
Note for reviewer
The full test suite was not run locally, so I'm relying on CI to confirm.
AI-assisted.