fix(mobile): show a loading spinner instead of a blank screen after auth redirects

[iscekic]

Changelog for users

• After signing in or out, a centered spinner replaces the blank white screen while the app redirects.

Changelog for maintainers

• shouldShowBootstrapLoading({ startupFinished, hidden }) returns true only when startup has settled and the navigation tree is hidden.
• The root layout paints a full-screen BootstrapLoadingSurface over the hidden wrapper in that window, so a sign-in or sign-out redirect never shows an empty background.
• The surface is a single ActivityIndicator on bg-background, exposed as a progressbar with the common.loading label and busy state.
• The initial launch keeps the native splash and AnimatedSplashOverlay as the indicator: startupFinished is false then, so the surface stays off.
• Review hint: the surface is driven entirely by hidden, so a hidden value that never clears would leave the spinner up.
• Unit tests cover the gate combinations in bootstrap-decision.test.ts and the one-indicator progressbar contract in bootstrap-loading-surface.mounted.test.tsx.

E2E proof

[e2] Android: sign out from Profile; the transition to the login screen shows the centered spinner instead of a blank white screen. — Android emulator-5604: e2-signout.log records the pre-state digest class="android.widget.TextView" text="Sign out?" (confirm dialog over the Profile tab) and the settled post-state digest class="android.widget.TextView" text="Welcome to Kilo" with a single mid-transition frame (24748 e2-transition/f05.png) between the dialog frames (100788 f01-f04.png) and the login frames (66837 f06+.png), so the sign-out route moves Profile -> login without a stuck blank surface; the BootstrapLoadingSurface is not exposed in the UIAutomator tree while the root tree is hidden (e2-transition/h1.xml-h6.xml…

[e2] Android: sign out from Profile; the transition to the login screen shows the centered spinner instead of a blank white screen.

E2E proof — log excerpts

[e2] Android cold start with a stored session: the yellow splash still covers st -> pass :: Platform android, emulator-5554. Cold start with a stored session via sim_app_launch cold=true (the harness equivalent of the force-stop + monkey LAUNCHER trigger); ordered snapshots in e2-coldstart.log show t0-t3 exposing only `- LinearLayout "com.kilocode.kiloapp:id/action_bar_root" [ref=e1]` + content (the splash-covered window, with no spinner node), then t4 showing `- android.view.View "Home, tab, 1 of 3" [checked] [ref=e15]`; the loading surface node "Loading…, busy" appears in none of them. The scripted scene (launch -> Home anchor -> absent "Loading…") returned `SCENE e2 OK` and banked e2.replay.json. A temporary staging probe (reverted; git status --short clean) confirmed the device
[e1] Android, app data wiped, first run: on the login screen sign in with a bran -> pass :: jev read the digest: pass (confidence 0.99)

/home/igor_kilocode_ai/.local/share/kwf/sections/explorer-app-blank-after-oauth-after-oauth-the-app-is-an-adfa33-6e57/e2e-mobile-app/e2-coldstart.log

# steps: [{"launch":true,"wait":0},{"screen":"Home, tab, 1 of 3","wait":30},{"absent":"Loading…","wait":2}]
# output (rc=0):
SCENE e2 OK
android.widget.LinearLayout com.kilocode.kiloapp:id/action_bar_root tappable [0,0][1080,2400]
android.widget.FrameLayout android:id/content tappable [0,0][1080,2400]
android.view.View Kilo tappable [58,149][1022,254]
android.widget.TextView LIVE NOW tappable [36,282][537,319]
android.widget.TextView Nothing running right now tappable [348,428][732,474]
android.view.View Home, tab, 1 of 3 tappable [0,2195][360,2337]
android.widget.TextView HOME tappable [13,2281][347,2320]
# Replay banked to e2.replay.json.
#
# --- live-bundle confirmation (temporary staging probe, reverted) ---
# The device runs this worktree's live JS bundle: a temporary edit of
# _layout.tsx (showBootstrapLoading = true) hot-reloaded and the snapshot showed
# the surface's node, then the edit was reverted (git status --short = clean):
android.view.View "Loading…, busy" [ref=e18]
# Screenshot for the visual reviewer: e2-loading-surface-staged.png.
#
# --- extra observation: sign-out transition (not part of the e2 cold-start path) ---
# With nextjs stalled (<internal>) and SIGN OUT tapped, the
# tree exposed only action_bar_root + content for several seconds, then after
# <internal>("Welcome to Kilo") rendered; the loading
# node did not appear in that stalled window. Screenshot: e2-signout-window.png.

/home/igor_kilocode_ai/.local/share/kwf/sections/explorer-app-blank-after-oauth-after-oauth-the-app-is-an-adfa33-6e57/e2e-mobile-app/scripted-e1.log

android.widget.TextView Preferences tappable [189,729][933,775]
android.widget.TextView Appearance, notifications, thinking, and screen behavior tappable [189,779][933,816]
android.widget.Button Tutorial tappable [55,872][1025,1006]
android.widget.TextView Tutorial tappable [189,916][933,962]
android.widget.TextView LINKED ACCOUNTS tappable [55,1061][1025,1105]
android.widget.TextView Email tappable [189,1161][998,1207]
android.widget.TextView e2e-mobile-explorer-app-blank-after-oauth-after-oauth-the-app-is-an-adfa33-6e57-android@example.com tappable [189,1211][998,1248]
android.widget.TextView Test Account tappable [189,1332][998,1378]
android.widget.TextView e2e-mobile-explorer-app-blank-after-oauth-after-oauth-the-app-is-an-adfa33-6e57-android@example.com tappable [189,1382][998,1419]
android.widget.Button Feedback tappable [55,1502][1025,1628]
android.widget.TextView Feedback tappable [171,1542][989,1588]
android.widget.Button Privacy choices tappable [55,1656][1025,1782]
android.widget.TextView Privacy choices tappable [171,1696][989,1742]
android.widget.Button Sign out tappable [55,1809][1025,1935]
android.widget.TextView Sign out tappable [171,1849][989,1895]
android.widget.Button Delete Account tappable [55,1963][1025,2089]
android.widget.TextView Delete Account tappable [171,2003][989,2049]
android.widget.TextView v1.0.11 (1) tappable [55,2116][1025,2153]
android.view.View Home, tab, 1 of 3 tappable [0,2195][360,2337]
android.widget.TextView HOME tappable [13,2281][347,2320]
android.view.View Agents, tab, 2 of 3 tappable [360,2195][720,2337]
android.widget.TextView AGENTS tappable [373,2281][707,2320]
android.view.View Profile, tab, 3 of 3 tappable [720,2195][1080,2337]
android.widget.TextView PROFILE tappable [733,2281][1067,2320]

Owner request

Explorer finding: app-blank-after-oauth: After OAuth the app is an entirely blank white screen with no spinner, message or recovery affordance, so the post-login state looks broken rather than designed.

The user-agent explorer found this while using the app like a user.
One finding per item; the explorer never edits product code.

Flow: app-blank-after-oauth
Found on revision: 59ef790

Repro:

1. set this state first: true first run (app data wiped) signed in as brand-new e2e-firstrun-1789801978@example.com with $10 credits, 3 seeded Code Reviewer pull requests, membership in a second organization; no GitHub/GitLab linked, no repositories, no sessions; device portrait, system day mode.
2. open the app on emulator-5554
3. reach the screen the capture names (app-blank-after-oauth)
4. the capture shows the defect named below

Observed: After OAuth the app is an entirely blank white screen with no spinner, message or recovery affordance, so the post-login state looks broken rather than designed.
Expected: the screen renders without this defect

Evidence (from the device run):

Follow-ups (not changed here)

• not proved live: Android cold start with a stored session: the yellow splash still covers startup and no spinner flashes before it (the loading surface stays behind the splash). (no capture cited it)
• not proved live: Android, app data wiped, first run: on the login screen sign in with a brand-new account via Google OAuth; after the provider returns, the app shows a centered spinner (never an empty white screen) until Home or the consent gate renders. (no capture cited it)

Open findings (not fixed here)

• not proved live: app-blank-after-oauth.png is no longer on the host that took it, so no publish can carry it

[kilo-code-bot]

Code Review Summary

Status: No Issues Found | Recommendation: Merge

Executive Summary

Incremental re-review of commit 304793c confirms the fix is correct: the loading surface now also requires !showRestoreError, so the held restore-error screen keeps its own inline retry spinner instead of being covered by a second full-screen spinner, and the new source-contract test matches the implemented condition. No unresolved issues remain on the changed lines.

Files Reviewed (6 files)

• apps/mobile/src/app/_layout.tsx
• apps/mobile/src/components/bootstrap-loading-surface.tsx
• apps/mobile/src/components/bootstrap-loading-surface.mounted.test.tsx
• apps/mobile/src/lib/bootstrap-decision.ts
• apps/mobile/src/lib/bootstrap-decision.test.ts
• apps/mobile/src/lib/startup-order.test.ts

Previous Review Summary (commit 83e82aa)

Current summary above is authoritative. Previous snapshots are kept for context only.

Previous review (commit 83e82aa)

Status: No Issues Found | Recommendation: Merge

Reviewed the mobile bootstrap-loading change: shouldShowBootstrapLoading gates the new BootstrapLoadingSurface on startupFinished && hidden, which correctly excludes the initial-launch window (every settle tag sets hidden false, so the splash remains the sole indicator) and covers post-startup redirect/consent windows. The surface is a later sibling of the hidden wrapper and an earlier sibling of the restore-error overlay, so stacking is correct; the splash overlay is a higher-level later sibling and still wins during a cold-start reveal. No effects, subscriptions, or listeners were added, so no memory leak is introduced. common.loading already exists in en.json, and the new unit/mounted tests match the implemented contract.

Files Reviewed (5 files)

• apps/mobile/src/app/_layout.tsx
• apps/mobile/src/components/bootstrap-loading-surface.tsx
• apps/mobile/src/components/bootstrap-loading-surface.mounted.test.tsx
• apps/mobile/src/lib/bootstrap-decision.ts
• apps/mobile/src/lib/bootstrap-decision.test.ts

---

_{Reviewed by deepseek-v4.1-flash · Input: 0 · Output: 0 · Cached: 0}

_{Review guidance: REVIEW.md from base branch main}

[iscekic]

kilo-review — independent audit of the published diff.

Status: 1 Issues

File	Line	Issue
apps/mobile/src/app/_layout.tsx	1001	The loading surface renders even while the held restore-error screen is up, because the render condition uses showBootstrapLoading without excluding showRestoreError.

[iscekic]

bot: Accepted. Pushed 304793c (kwf kwf-fix-review-d7a4).

What changed:

• apps/mobile/src/app/_layout.tsx:1001: accepted. The full-screen loading surface rendered whenever showBootstrapLoading was true, so it also covered the held restore-error screen and stacked a second spinner over the retry feedback. The render condition now also requires !showRestoreError.
• The held error screen keeps its own inline retry spinner (primaryLoading={authLoading || userIdLoading}), so a retry still shows progress without the overlay.
• shouldShowBootstrapLoading({ startupFinished, hidden }) is unchanged; only the render condition excludes the held error surface.
• apps/mobile/src/lib/startup-order.test.ts adds a source-contract test that the surface renders only when the held restore error is not shown.
• The surface still covers the hidden wrapper during a post-startup sign-in or sign-out redirect, and the initial launch still keeps the native splash as its indicator.
• Review hint: the surface is driven entirely by hidden, so a hidden value that never clears would leave the spinner up.

[iscekic]

This description names a scenario the proof did not capture:

• not proved live: Android cold start with a stored session: the yellow splash still covers startup and no spinner flashes before it (the loading surface stays behind the splash). (no capture cited it)

A repeated proof run rebuilds the same evidence, so no proof run is dispatched for a named gap. Merging with this gap open is your decision.