Skip to content

fix(mobile): hide connect prompt after a repository is selected - #6358

Open
iscekic wants to merge 1 commit into
mainfrom
kwf/explorer-new-session-filled-after-a-github-repository-and-7bcc6-3a42
Open

iscekic wants to merge 1 commit into
mainfrom
kwf/explorer-new-session-filled-after-a-github-repository-and-7bcc6-3a42

Conversation

@iscekic

@iscekic iscekic commented Sep 19, 2026

Copy link
Copy Markdown
Collaborator

Changelog for users

  • Before a repository is chosen, the expanded Connect GitLab prompt still shows its instructions, browser action, and refresh action.
  • After a repository is chosen, the expanded connection prompt no longer appears beneath the Branch field.
  • Compact provider-specific Connect and refresh actions remain available after selection, so another provider can be connected without clearing the repository.
  • After a provider connects and repositories refresh, its repositories remain selectable with the existing branch and Sandbox controls.
  • After a repository is chosen, the compact Bitbucket connect action states that Bitbucket is available for organizations only.

Changelog for maintainers

  • apps/mobile/src/components/agents/new-session-repository-section.tsx:175 — accepted: the selection gate hid every unconnected provider; selected states now render compact connect and refresh actions.
  • apps/mobile/src/components/agents/new-session-repository-section.tsx:173 — accepted: the compact Bitbucket action omitted the organizations-only restriction; the selected state now renders the shared note above compact actions, leaving GitHub and GitLab unchanged.
  • The expanded prompt remains pre-selection, while compact actions preserve provider-specific connection access after selection; the Bitbucket note uses the same helper.
  • The shared action helper preserves collapse behavior, refresh retry state, and disabled spinner feedback.
  • Provider-aware selection still distinguishes same-name repositories by platform and full name.
  • Unit tests cover provider-specific note rendering, compact actions, branch identity, retry states, provider errors, connected-empty guidance, collapse, and pre-selection behavior.
  • Browser-return evidence shows the repository and branch remain unchanged after the compact connection action opens the browser.
  • The former zero-GitLab-occurrences proof and missing-screenshot proof are superseded by live UI-tree evidence for selected actions and the pre-selection Bitbucket card. Evidence collected 2026-09-19 retains the missing-screenshot limitation; visual/UX judgment remains skipped pending owner verification.

E2E proof

Owner request

Explorer finding: new-session-filled: After a GitHub repository and branch are chosen, the "Connect GitLab … then return here to pick a repository" card is still expanded directly beneath the Branch field, contradicting the completed selection.

The user-agent explorer found this while using the app like a user.
One finding per item; the explorer never edits product code.

Flow: new-session-filled
Found on revision: 59ef790

Repro:

  1. set this state first: account e2e-mobile-cloud-android@example.com signed in, $10 credits, a second organization, 3 Code Reviewer pull requests, one idle top-level session (ses_f47517985ffeuS0nu3ltxEpHaI) linked to PR fix(ci): drop unused pull-requests scope from kilo-app CI #4821, system day mode, app UI in Arabic (persisted from a prior round), device portrait.; the device in light mode
  2. open the app on emulator-5602
  3. reach the screen the capture names (new-session-filled)
  4. the capture shows the defect named below

Observed: After a GitHub repository and branch are chosen, the "Connect GitLab … then return here to pick a repository" card is still expanded directly beneath the Branch field, contradicting the completed selection.
Expected: the screen renders without this defect

Evidence (from the device run):

Production record (automatic, 2026-09-19):

Production record for ses_f47517985ffeuS0nu3ltxEpHaI

Axiom, last 72 h

No line carries this term in: vercel, cloudflare-logpush, supabase-production.

The session row, read replica

No row in cli_sessions_v2 carries ses_f47517985ffeuS0nu3ltxEpHaI.

Log archives, R2 kilocode-sessions

NOT READ: R2 keys are indexed by the agent id, not the session id; take the agent_* from the worker logs above and query that.

Sentry, last 72h

No Sentry issue carries this term.

E2E proof — log excerpts

[e1] Select a GitHub repository while Bitbucket is unconnected (personal session -> pass :: Android emulator-5554: 'SCENE e1 OK' (e1-dispatch.log); after GitHub selection the digest shows 'android.widget.TextView Bitbucket is available for organizations only. tappable [37,1730][1045,1776]' above 'android.widget.Button Connect Bitbucket tappable [37,1794][909,1909]' with 'android.widget.Button Repository: GitHub · iscekic/panon-deking tappable [37,1240][1043,1356]' and 'android.widget.Button Branch: main tappable [37,1448][1043,1559]' still selected after the compact connect action returned.
/home/igor_kilocode_ai/.local/share/kwf/sections/kwf-fix-review-7921/e2e-mobile-app/e1-dispatch.log
android.widget.TextView Run `kilo remote` on your computer, or `/remote` in a running CLI session, to control a local kilo process. tappable [36,1056][1044,1130]
android.widget.TextView Repository tappable [37,1176][1045,1222]
android.widget.Button Repository: GitHub · iscekic/panon-deking tappable [37,1240][1043,1356]
android.widget.TextView GitHub · iscekic/panon-deking tappable [67,1270][978,1326]
android.widget.TextView Branch tappable [37,1384][1045,1430]
android.widget.Button Branch: main tappable [37,1448][1043,1559]
android.widget.TextView main tappable [67,1475][850,1531]
android.widget.TextView Default tappable [867,1484][958,1521]
android.widget.Button Connect GitLab tappable [37,1587][909,1703]
android.widget.TextView Connect GitLab tappable [389,1621][617,1667]
android.widget.Button Refresh repositories tappable [928,1587][1043,1703]
android.widget.TextView Bitbucket is available for organizations only. tappable [37,1730][1045,1776]
android.widget.Button Connect Bitbucket tappable [37,1794][909,1909]
android.widget.TextView Connect Bitbucket tappable [367,1828][640,1874]
android.widget.Button Refresh repositories tappable [928,1794][1043,1909]
android.widget.TextView Sandbox tappable [37,1955][1045,2001]
android.widget.Button Sandbox: Default · Cloudflare · Small tappable [37,2019][1043,2135]
android.widget.TextView Default · Cloudflare · Small tappable [67,2049][978,2105]
android.widget.TextView Changes tappable [37,2182][1045,2228]
android.view.View Changes tappable [37,2246][1043,2337]
android.widget.RadioButton Leave changes tappable [46,2255][540,2337]
android.widget.TextView Leave changes tappable [182,2282][403,2328]
android.widget.RadioButton Commit and push tappable [540,2255][1034,2337]
android.widget.TextView Commit and push tappable [656,2282][917,2328]

Comment thread apps/mobile/src/components/agents/new-session-repository-section.tsx Outdated
@kilo-code-bot

kilo-code-bot Bot commented Sep 19, 2026

Copy link
Copy Markdown
Contributor

Code Review Summary

Status: 1 Issue Found | Recommendation: Address before merge

Executive Summary

The rewritten commit fixes the previously reported unreachable connect entry point, but the new compact Bitbucket action drops the organizations-only restriction that the file documents as mandatory, so a personal-session user can tap an unqualified "Connect Bitbucket".

Overview

Severity Count
CRITICAL 0
WARNING 1
SUGGESTION 0
Issue Details (click to expand)

WARNING

File Line Issue
apps/mobile/src/components/agents/new-session-repository-section.tsx 173 Compact connect action for an unconnected Bitbucket renders without the bitbucketOrganizationsOnly note; after selection the earlier expanded card no longer carries it either.
Files Reviewed (4 files)
  • apps/mobile/src/components/agents/new-session-repository-section.tsx - 1 issue
  • apps/mobile/src/components/agents/new-session-repository-section.test.ts - 0 issues
  • apps/mobile/src/components/agents/new-session-repository-section.test-helpers.ts - 0 issues
  • apps/mobile/src/lib/case-guard.test.ts - 0 issues

Fix these issues in Kilo Cloud

Previous Review Summaries (2 snapshots, latest commit 140e280)

Current summary above is authoritative. Previous snapshots are kept for context only.

Previous review (commit 140e280)

Status: 1 Issue Found | Recommendation: Address before merge

Executive Summary

The rewritten commit fixes the previously reported unreachable connect entry point, but the new compact Bitbucket action drops the organizations-only restriction that the file documents as mandatory, so a personal-session user can tap an unqualified "Connect Bitbucket".

Overview

Severity Count
CRITICAL 0
WARNING 1
SUGGESTION 0
Issue Details (click to expand)

WARNING

File Line Issue
apps/mobile/src/components/agents/new-session-repository-section.tsx 173 Compact connect action for an unconnected Bitbucket renders without the bitbucketOrganizationsOnly note; after selection the earlier expanded card no longer carries it either.
Files Reviewed (4 files)
  • apps/mobile/src/components/agents/new-session-repository-section.tsx - 1 issue
  • apps/mobile/src/components/agents/new-session-repository-section.test.ts - 0 issues
  • apps/mobile/src/components/agents/new-session-repository-section.test-helpers.ts - 0 issues
  • apps/mobile/src/lib/case-guard.test.ts - 0 issues

Fix these issues in Kilo Cloud

Previous review (commit 18061a2)

Status: 1 Issue Found | Recommendation: Address before merge

Executive Summary

The new selection gate hides every unconnected provider's connect card, making the connect action unreachable once any repository is selected.

Overview

Severity Count
CRITICAL 0
WARNING 1
SUGGESTION 0
Issue Details (click to expand)

WARNING

File Line Issue
apps/mobile/src/components/agents/new-session-repository-section.tsx 175 Gating on selectedRepository === null hides every unconnected provider's connect card. The repo picker only ever selects a repository key, so there is no way to clear the selection; a user who picks a repo cannot reach the Open GitLab / Open Bitbucket actions without leaving and re-entering the screen.
Files Reviewed (2 files)
  • apps/mobile/src/components/agents/new-session-repository-section.tsx - 1 issue
  • apps/mobile/src/components/agents/new-session-repository-section.test.ts - 0 issues

Fix these issues in Kilo Cloud


Reviewed by deepseek-v4.1-flash · Input: 0 · Output: 0 · Cached: 0

Review guidance: REVIEW.md from base branch main

@iscekic
iscekic marked this pull request as draft September 19, 2026 09:58
@iscekic
iscekic force-pushed the kwf/explorer-new-session-filled-after-a-github-repository-and-7bcc6-3a42 branch from ce91c46 to 140e280 Compare September 19, 2026 15:28
@iscekic
iscekic marked this pull request as ready for review September 19, 2026 15:48
Comment thread apps/mobile/src/components/agents/new-session-repository-section.tsx Outdated
@iscekic
iscekic marked this pull request as draft September 19, 2026 16:05
@iscekic
iscekic force-pushed the kwf/explorer-new-session-filled-after-a-github-repository-and-7bcc6-3a42 branch from fb05873 to ba8871f Compare September 19, 2026 18:19
@iscekic
iscekic marked this pull request as ready for review September 19, 2026 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant