Conversation
Explorer finding: session-error: The same failure is stated three times in near-identical copy ("Response failed", "The response failed.", "The response failed."), which reads as a glitch rather than a designed error state.
The user-agent explorer found this while using the app like a user.
One finding per item; the explorer never edits product code.
Flow: session-error
Found on revision: fd04ca1
Repro:
1. set this state first: account e2e-mobile-cloud-android@example.com signed in via emailed code (~$258.98 credits), Code Reviewer seeded with 3 pull requests (the `checks` state is blocked by a harness preflight: tracked edits present), a second organization to switch to, one needs-input session; system night mode, display size 480x1040, portrait.
2. open the app on emulator-5554
3. reach the screen the capture names (session-error)
4. the capture shows the defect named below
Observed: The same failure is stated three times in near-identical copy ("Response failed", "The response failed.", "The response failed."), which reads as a glitch rather than a designed error state.
Expected: the screen renders without this defect
Evidence (from the device run):
- ~/.local/share/kwf/findings/explorer-session-error-the-same-failure-is-stated-three-t-795818de/session-error.png
Contributor
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Executive SummaryReviewed the mobile failure-dedup change across 12 files: the nullable Files Reviewed (12 files)
Reviewed by deepseek-v4.1-flash · Input: 0 · Output: 0 · Cached: 0 Review guidance: REVIEW.md from base branch |
Collaborator
Author
|
This description names a scenario the proof did not capture:
A repeated proof run rebuilds the same evidence, so no proof run is dispatched for a named gap. Merging with this gap open is your decision. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog for users
Changelog for maintainers
MessageFailure.detailis now nullable; an unknown assistant error name produces no detail line instead of the generic sentence.detailis null.statusIndicatorDuplicatesMessageFailuredrops the footer error indicator only when its resolved copy matches the row's title, the row's detail, or the generic assistant line; any other line is kept.lastVisibleMessageFailureresolves the failure the transcript's last rendered row owns and walks back past rowsmergeSessionTranscriptdrops.transcriptRendersMessageis extracted frommergeSessionTranscriptwith unchanged rendering.E2E proof
[e1] assistant failure row suppresses the duplicate footer line — Live on android emulator-5554 the last assistant row shows 'Response failed. Retry available.' with a Retry and the digest contains no 'The response failed.' footer line while the session run is failed (session-level error) per e1-session-run.log; screenshot e1-response-failed.png.
[e3] dropped assistant failure row keeps the footer error line — With no assistant failure row rendered and the session run failed (wrapper_disconnected, e3-session-run.log), the fixed footer shows the error line 'The response failed.' and no row text, so the failure keeps a surface; screenshot e3-footer-error.png.
E2E proof — log excerpts
/home/igor_kilocode_ai/.local/share/kwf/sections/explorer-session-error-the-same-failure-is-stated-three-t-79581-b217/e2e-mobile-app/e1-footer-credits-digest.txt/home/igor_kilocode_ai/.local/share/kwf/sections/explorer-session-error-the-same-failure-is-stated-three-t-79581-b217/e2e-mobile-app/e1-control-digest.txtOwner request
Follow-ups (not changed here)
Open findings (not fixed here)