Conversation
Explorer finding: composer-repo-chosen: The primary 'Start session' label is low-contrast olive-on-olive in the dark theme even though the form is complete, so the main action reads as disabled and is hard to read. The user-agent explorer found this while using the app like a user. One finding per item; the explorer never edits product code. Flow: composer-repo-chosen Found on revision: fd04ca1 Repro: 1. set this state first: account e2e-mobile-cloud-android@example.com signed in, $10 credits, 3 Code Reviewer pull requests, a second organization to switch to, display size 1440x3200, system day mode, portrait. 2. open the app on emulator-5554 3. reach the screen the capture names (composer-repo-chosen) 4. the capture shows the defect named below Observed: The primary 'Start session' label is low-contrast olive-on-olive in the dark theme even though the form is complete, so the main action reads as disabled and is hard to read. Expected: the screen renders without this defect Evidence (from the device run): - ~/.local/share/kwf/findings/explorer-composer-repo-chosen-the-primary-start-session-l-dfecb6b6/composer-repo-chosen.png
iscekic
marked this pull request as draft
September 19, 2026 08:38
Contributor
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Executive SummaryReviewed the disabled-primary button treatment (new Files Reviewed (9 files)
Reviewed by deepseek-v4.1-flash · Input: 0 · Output: 0 · Cached: 0 Review guidance: REVIEW.md from base branch |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog for users
Changelog for maintainers
opacity-50, compositing the brand fill and ink into olive-on-olive; the disabled primary no longer dims.--primary-disabledtoken (light#6F6A61, dark#8A8680) inapps/mobile/src/global.css, generated intotheme-colors.generated.tsbygenerate-theme-colors.mjs.bg-primary-disabledand skipopacity-50; non-default variants keepopacity-50.bg-primaryand the inline spinner;new-session-start-button.tsxpassesloadinginstead of rendering its ownActivityIndicator.primaryForegroundonprimaryDisabledclears 4.5:1 in both themes; mounted Button and bootstrap-error-screen tests cover the class precedence.bg-primary-disabledmerges after the variant fill so it wins overbg-primary, and that the busy path never takes the muted fill.E2E proof — log excerpts
Open findings (not fixed here)