Conversation
Explorer finding: home: Section header is mirrored versus the same header on agents.png: the title sits left and "عرض الكل" sits right, so section headers do not share one alignment. The user-agent explorer found this while using the app like a user. One finding per item; the explorer never edits product code. Flow: home Found on revision: fd04ca1 Repro: 1. set this state first: brand-new first-run account (via `fresh`) with $10 credits, a second organization, 3 Code Reviewer PRs, seeded with `app:mobile-sheet-fixtures`, device in landscape reverse? Hmm. 2. open the app on emulator-5602 3. reach the screen the capture names (home) 4. the capture shows the defect named below Observed: Section header is mirrored versus the same header on agents.png: the title sits left and "عرض الكل" sits right, so section headers do not share one alignment. Expected: the screen renders without this defect Evidence (from the device run): - ~/.local/share/kwf/findings/explorer-home-section-header-is-mirrored-versus-the-same-6caf948e/home.png
Contributor
Code Review SummaryStatus: No Issues Found | Recommendation: Merge The Home section-header action is now placed with direction-relative Files Reviewed (2 files)
Reviewed by deepseek-v4.1-flash · Input: 0 · Output: 0 · Cached: 0 Review guidance: REVIEW.md from base branch |
Collaborator
Author
|
This description names a scenario the proof did not capture:
A repeated proof run rebuilds the same evidence, so no proof run is dispatched for a named gap. Merging with this gap open is your decision. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog for users
Changelog for maintainers
flex-rowwithjustify-end, so its placement follows the layout direction.text-left/text-rightalignment that React Native swaps under RTL on Android.I18nManager.isRTL; the component drops itsI18nManagerandcnimports.flex-rowending atjustify-endin both directions.E2E proof
[e1] Arabic (RTL) device: on Home, the 'Live now' section header shows its title flush with the right inset and 'عرض الكل' flush with the left inset, at the same edge as the Agents tab's section-header… — android emulator-5554, app language set to Arabic (RTL) via Profile > Preferences > Account > Language; the Home digest (e1-scene.log) shows the title 'الجلسات الجارية الآن' box [496,282][1044,328] with right edge 1044 flush to the Home content right edge 1043 and 'عرض الكل' [37,281][160,330] with left edge 37 at the Home content left inset, and the Agents tab count 'الجلسات النشطة: 0' [209,149][1024,195] (e1-agents-rtl.xml) is likewise right-anchored in RTL, so the header is no longer mirrored; screenshots e1.png/e1-home-rtl.png for the visual reviewer; no UX-DEFECT on Home/Agents RTL.
[e2] English (LTR) device: on Home, 'Live now' stays left and 'See all' stays flush with the right inset (no regression). — Platform android (emulator-5604), signed in as the default e2e account; state e2-home.log shows SCENE e2 OK with digest nodes 'LIVE NOW' [36,282][537,319] (left bound 36 = the 36/37 left inset of sibling rows) and 'SEE ALL' [897,281][1043,320] (right bound 1043 = the 1043/1044 right edge of sibling full-width rows) on a 1080 px screen, so on this LTR Home the label sits at the left inset and the action copy at the row end; the tab round-trip replay (e2-replay.log, e2.replay.json) reports identical bounds, so no layout shift on data re-arrival; screenshot e2.png captured for the visual…
[e3] Tap 'See all'/'عرض الكل' on Home in either language: the Agents tab opens as before. — android emulator-5554; English (device language) Home, tapping 'See all' opened the Agents tab (digest after the tap shows '0 LIVE', 'Agents', 'See all' in e3-en-scene.log), and the same holds in Arabic where tapping 'عرض الكل' opened the Agents tab (e3-scene.log digest shows 'الجلسات النشطة: 0', 'الوكلاء'); screenshots e3.png (English Agents), e3-ar.png (Arabic Agents), e3-home-en.png; no UX-DEFECT.
[e3] Tap 'See all'/'عرض الكل' on Home in either language: the Agents tab opens as before.
E2E proof — log excerpts
/home/igor_kilocode_ai/.local/share/kwf/sections/explorer-home-section-header-is-mirrored-versus-the-same-6caf94-8e8e/e2e-mobile-app/e1-scene.log/home/igor_kilocode_ai/.local/share/kwf/sections/explorer-home-section-header-is-mirrored-versus-the-same-6caf94-8e8e/e2e-mobile-app/e3-en-scene.log/home/igor_kilocode_ai/.local/share/kwf/sections/explorer-home-section-header-is-mirrored-versus-the-same-6caf94-8e8e/e2e-mobile-app/e3-scene.log/home/igor_kilocode_ai/.local/share/kwf/sections/explorer-home-section-header-is-mirrored-versus-the-same-6caf94-8e8e/e2e-mobile-app/e2-home.log/home/igor_kilocode_ai/.local/share/kwf/sections/explorer-home-section-header-is-mirrored-versus-the-same-6caf94-8e8e/e2e-mobile-app/e2-replay.logOwner request
Open findings (not fixed here)