(janitor/comments): remove narration and banner comments from app-builder - #6351
Open
kilo-code-bot[bot] wants to merge 1 commit into
Open
kilo-code-bot[bot] wants to merge 1 commit into
kilo-code-bot[bot] wants to merge 1 commit into
Conversation
…lder Comment-only cleanup of services/app-builder. No behavior, types, or public API changes: 375 comment lines and 25 resulting blank lines removed across 21 files. Removed: step-by-step narration of the next line, git-protocol and TAR-parsing step labels, section banners, routing restatements, numbered migration steps, test step/phase narration, and a stale self-referential path comment. Kept: protocol and TAR format offsets, empty-repo advertisement semantics, sideband/unpack-status rules, oversized-pack and persist-before-success invariants, legacy-token compatibility notes, HEAD bootstrap rule, pkill exit-code semantics, TAR end-of-archive markers, and no-empty-required empty-catch comments.
Contributor
Author
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Executive SummaryReviewed 21 files of comment-only cleanup in Files Reviewed (21 files)
Reviewed by deepseek-v4.1-flash · Input: 0 · Output: 0 · Cached: 0 Review guidance: REVIEW.md from base branch |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Comment-only cleanup of
services/app-builder(App Builder Cloudflare Worker: git HTTP protocol, preview Durable Object, handlers, schemas, utils, and its git tests). All changes are comment deletions plus directly resulting blank-line removals — no behavior, type, test, or public-API changes.Package or topic area cleaned
services/app-builder— the git clone/push protocol pipeline (src/git/), the preview and git-repository Durable Objects, HTTP handlers, API schemas, shared utils, and the service's own unit and integration tests.Files touched (21)
src/git/git-receive-pack-service.ts,src/git/git-clone-service.ts,src/git/git-protocol-utils.ts,src/git/fs-adapter.ts,src/git/memfs.tssrc/handlers/git-protocol.ts,src/handlers/init.ts,src/handlers/preview.ts,src/handlers/delete.ts,src/handlers/migrate-to-github.tssrc/preview-do.ts,src/git-repository-do.ts,src/index.ts,src/types.ts,src/api-schemas.tssrc/utils/auth.ts,src/utils/push-notification.tssrc/git/git-receive-pack-service.test.ts,src/git/git-clone-service.test.tssrc/_integration_tests/test-git-head-and-history.ts,src/_integration_tests/test-git-integration.ts,src/_integration_tests/git-test-helpers.tsComment lines removed
5 insertions(+), 405 deletions(-)across 21 filesCategories of noise removed
// ===/// ---separators, including "Step N" and "Test N" banners duplicating adjacent log calls and test-suite names// Handle X requestsabove the matching pattern check)// 1. Fetch a GitHub token via git-token-service)// src/types.tspath comment)// P,// Write length,// Decode base64 to binary)Important comments intentionally retained
capabilities^{}advertisement, sideband/unpack-status rules, pkt-line format docsfull), empty-body init clients, raw-OID HEAD legacy-repo handlingpkillexit codes, DOdeleteAll()also clearing SQLite tables, cf-gitlistBranches()hang workaround, ephemeral GitHub token refresh@ts-expect-errordirective (untouched)no-emptylint rule (verified: removing them failsoxlint)Follow-up refactor candidates
None — no deleted comment was load-bearing for understanding beyond what the code expresses.
Validation performed
pnpm --filter app-builder typecheck(tsgo): passoxlint --config .oxlintrc.json services/app-builder/src: 0 errors, 0 warningspnpm --filter app-builder test(vitest): 4 files, 43/43 passedoxfmt --check services/app-builder/src: clean