Conversation
Explorer finding: repo-picker: The "Search repositories…" placeholder wraps onto a second line that is clipped by the field border. The user-agent explorer found this while using the app like a user. One finding per item; the explorer never edits product code. Flow: repo-picker Found on revision: fd04ca1 Repro: 1. set this state first: account e2e-mobile-cloud-android@example.com signed in via emailed code (~$258.98 credits), Code Reviewer seeded with 3 pull requests (the `checks` state is blocked by a harness preflight: tracked edits present), a second organization to switch to, one needs-input session; system night mode, display size 480x1040, portrait. 2. open the app on emulator-5554 3. reach the screen the capture names (repo-picker) 4. the capture shows the defect named below Observed: The "Search repositories…" placeholder wraps onto a second line that is clipped by the field border. Expected: the screen renders without this defect Evidence (from the device run): - ~/.local/share/kwf/findings/explorer-repo-picker-the-search-repositories-placeholder-283900c3/repo-picker.png
Contributor
Code Review SummaryStatus: No Issues Found | Recommendation: Merge The repo picker placeholder was moved from the native Files Reviewed (2 files)
Reviewed by deepseek-v4.1-flash · Input: 0 · Output: 0 · Cached: 0 Review guidance: REVIEW.md from base branch |
Collaborator
Author
|
This description names a scenario the proof did not capture:
A repeated proof run rebuilds the same evidence, so no proof run is dispatched for a named gap. Merging with this gap open is your decision. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog for users
Changelog for maintainers
pointerEvents="none", so taps still reach the field and the field keeps its fixed height.leading-[normal]and a centred text rect, so the placeholder and the typed text align.textAlignVertical="center".E2E proof
[e1] On emulator-5554 at display size 480x1040 portrait (night mode), open the repo picker (New session -> Run on -> Select repository): the 'Search repositories…' placeholder renders on one line… — android/emulator-5554: e1-picker.log shows the EditText with hint="" showing-hint="false" bounds [130,1414][1017,1489] and a single overlay TextView text="Search repositories..." bounds [130,1425][1016,1476] (one 51px line, centre y=1450.5 = field centre 1451.5) — the native hint is gone so nothing wraps; e1.png captured for the visual reviewer.
[e2] In the same repo picker, type a query: the placeholder disappears and the typed text occupies the same position with no vertical or horizontal shift. — android/emulator-5554: e2-typed.log shows the EditText text="tax" hint="" and the placeholder TextView count is 0 in e2-hierarchy.xml (node absent), while the list filtered to iscekic/tax-report-generator; the absolutely-inset overlay is removed from the fixed-height input so no position shift is possible; e2.png captured for the visual reviewer.
E2E proof — log excerpts
/home/igor_kilocode_ai/.local/share/kwf/sections/explorer-repo-picker-the-search-repositories-placeholder-283900-0576/e2e-mobile-app/e1-picker.log/home/igor_kilocode_ai/.local/share/kwf/sections/explorer-repo-picker-the-search-repositories-placeholder-283900-0576/e2e-mobile-app/e2-typed.logOwner request
Open findings (not fixed here)