Conversation
Explorer finding: a control is too small to tap reliably The user-agent explorer found this while using the app like a user. One finding per item; the explorer never edits product code. Flow: accessibility Found on revision: fd04ca1 Repro: 1. open the app on emulator-5554 2. reach the screen the capture names (the screen the capture names) 3. the capture shows the defect named below Observed: controls below 28dp on a side: agents: 1 small control(s): Filter sessions (52x52px) org-manage: 1 small control(s): Rename organization (42x42px) org-members: 1 small control(s): Invite member (57x57px) profile-org: 1 small control(s): Rename organization (42x42px) Expected: every control is at least 28dp on a side Evidence (from the device run): - ~/.local/share/kwf/findings/explorer-a-control-is-too-small-to-tap-reliably-6790f7d4/agents.png - ~/.local/share/kwf/findings/explorer-a-control-is-too-small-to-tap-reliably-6790f7d4/home-ar.png - ~/.local/share/kwf/findings/explorer-a-control-is-too-small-to-tap-reliably-6790f7d4/home-dark.png - ~/.local/share/kwf/findings/explorer-a-control-is-too-small-to-tap-reliably-6790f7d4/home.png
Contributor
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Executive SummaryReviewed the new shared Files Reviewed (10 files)
Reviewed by deepseek-v4.1-flash · Input: 0 · Output: 0 · Cached: 0 Review guidance: REVIEW.md from base branch |
Collaborator
Author
|
This description names a scenario the proof did not capture:
A repeated proof run rebuilds the same evidence, so no proof run is dispatched for a named gap. Merging with this gap open is your decision. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog for users
Changelog for maintainers
IconButtonrenders icon-only controls in a 32×32pt box with 8pthitSlop, giving a 48pt effective target over the 28dp accessibility minimum and the 44pt DESIGN.md minimum.SessionFilterButton, the organization hub rename pencil, and the members Invite member control now render throughIconButton, with the icon centered in a 20pt inner box.apps/mobile/src/components/ui/icon-button.tsxfirst: confirm callerclassNamemerges after the default box and that any callerhitSlopoverride stays adequate.E2E proof
[e2] Profile -> Organization: tap the pencil 'Rename organization' beside the organization name -> the rename sheet opens and saving a new name updates the row. — android (emulator-5604). One scripted scene from the personal Profile switched to the org ([seed:w4c-org-pair] e2e-org-owner-...), opened Manage organization, tapped the pencil, typed into 'Enter organization name' and tapped Save; e2-scene.log line 1 is 'SCENE e2 OK' and its post-save digest shows the hub header row 'android.view.View e2e-org-renamed tappable [111,167][1044,232]' where the seeded name was before (the DB row cd41b3f7-... became 'e2e-org-renamed', then I restored the 107-char seeded name in e2-restore.log so other shards are unaffected). Screenshot e2.png captured for the…
[e5] Re-run the explorer's control-size scan on Agents, Organization (both entries) and Organization Members: no control under 28dp on a side is reported (previously Filter sessions 52x52px, Rename… — android (emulator-5604, density 2.625 -> 28dp = 73.5px). Scan of the four screens' a11y hierarchies (e5-agents.xml, e5-org-index.xml, e5-org-deeplink.xml, e5-org-members.xml) reports 'Filter sessions <-- scanned control 28dp-OK', 'Rename organization <-- scanned control 28dp-OK' (hub via profile entry and via the organization/ deep link) and 'Invite member <-- scanned control 28dp-OK', all measured 84x84px = 32.0x32.0dp, up from 52/42/57px; no icon control under 28dp. Screenshots e5-agents.png, e5-org-index.png, e5-org-deeplink.png, e5-org-members.png captured for the visual reviewer (not…
[e5] Re-run the explorer's control-size scan on Agents, Organization (both entries) and Organization Members: no control under 28dp on a side is reported (previously Filter sessions 52x52px, Rename…
E2E proof — log excerpts
/home/igor_kilocode_ai/.local/share/kwf/sections/explorer-a-control-is-too-small-to-tap-reliably-6790f7d4-3a6c/e2e-mobile-app/e1-script.log/home/igor_kilocode_ai/.local/share/kwf/sections/explorer-a-control-is-too-small-to-tap-reliably-6790f7d4-3a6c/e2e-mobile-app/e1-hub.log/home/igor_kilocode_ai/.local/share/kwf/sections/explorer-a-control-is-too-small-to-tap-reliably-6790f7d4-3a6c/e2e-mobile-app/e1b-manage-hub.log/home/igor_kilocode_ai/.local/share/kwf/sections/explorer-a-control-is-too-small-to-tap-reliably-6790f7d4-3a6c/e2e-mobile-app/e1-members.logOwner request
Follow-ups (not changed here)
Open findings (not fixed here)