Skip to content

fix(mobile): make Connect GitHub action full-width on manual review screen - #6337

Open
iscekic wants to merge 1 commit into
mainfrom
kwf/explorer-manual-review-connect-provider-the-connect-githu-2f462-d2c6
Open

iscekic wants to merge 1 commit into
mainfrom
kwf/explorer-manual-review-connect-provider-the-connect-githu-2f462-d2c6

Conversation

@iscekic

@iscekic iscekic commented Sep 19, 2026

Copy link
Copy Markdown
Collaborator

Changelog for users

  • The Connect GitHub button on the Manual review screen now spans the full width, matching the same button on the PR Review connect screen.

Changelog for maintainers

  • ManualReviewScreen adds mt-3 w-full to the Connect GitHub Button inside its EmptyState action.
  • The classes match the PR-review connect gate and ProviderConnectCard, which already render this CTA full-width.
  • EmptyState renders the action node directly, so the classes reach the Button and cn() merges them after the variant classes.
  • A new mounted test asserts the action carries w-full and mt-3.
  • Review hint: one className change plus one test; no data, config, contract, or copy changes.

E2E proof

[e1] fresh account, Code Reviewer → Manual review Connect GitHub CTA full-width — android emulator-5554; e1-scene.log 'SCENE e1 OK' with 'android.widget.Button Connect GitHub tappable [55,1317][1025,1433]' on a 1080px screen (full width); fresh account had its seeded platform_integrations github row removed via db.sh to give the no-connection state, and Code Reviewer read 'GitHub, Not connected' (e1-manual-review-connect.png).

[e1] fresh account, Code Reviewer → Manual review Connect GitHub CTA full-width — prior/e1-manual-review-connect.png

[e1] fresh account, Code Reviewer → Manual review Connect GitHub CTA full-width — Android emulator-5554; after signing in a fresh account and removing the login.sh-seeded platform_integrations github row (the only way to reach the declared no-connection start state), the live scene digest in e1-scene.log (line 11) shows the CTA at full content width — 'android.widget.Button Connect GitHub tappable [55,1317][1025,1433]' — matching the PR-review connect gate reference in e2-connect.log (line 10) 'android.widget.Button Connect GitHub tappable [55,1318][1025,1433]'; screenshot e1.png written for the visual reviewer, no behavioural UX defect observed.

[e1] fresh account, Code Reviewer → Manual review Connect GitHub CTA full-width — e2e-mobile-app/e1.png

[e2] PR-review detail route GitHub gate CTA still full-width — android emulator-5554; PR Review entry + pasted URL + Open landed on the connect gate; e2-connect.log 'SCENE e2 OK' with 'android.widget.Button Connect GitHub tappable [55,1318][1025,1433]', identical width/margins to e1's [55,1317][1025,1433] (e2-pr-review-connect.png).

[e2] PR-review detail route GitHub gate CTA still full-width — prior/e2-pr-review-connect.png

E2E proof — log excerpts

[e1] fresh account, Code Reviewer → Manual review Connect GitHub CTA full-width -> pass :: Android emulator-5554; after signing in a fresh account and removing the login.sh-seeded platform_integrations github row (the only way to reach the declared no-connection start state), the live scene digest in e1-scene.log (line 11) shows the CTA at full content width — 'android.widget.Button Connect GitHub tappable [55,1317][1025,1433]' — matching the PR-review connect gate reference in e2-connect.log (line 10) 'android.widget.Button Connect GitHub tappable [55,1318][1025,1433]'; screenshot e1.png written for the visual reviewer, no behavioural UX defect observed.
/home/igor_kilocode_ai/.local/share/kwf/sections/explorer-manual-review-connect-provider-the-connect-githu-2f462-d2c6/e2e-mobile-app/e1-scene.log
SCENE e1 OK
android.widget.LinearLayout com.kilocode.kiloapp:id/action_bar_root tappable [0,0][1080,2400]
android.widget.FrameLayout android:id/content tappable [0,0][1080,2400]
android.widget.Button Go back tappable [0,152][101,253]
android.widget.TextView CODE REVIEWER tappable [111,149][1044,186]
android.view.View Manual review tappable [111,190][1044,255]
android.widget.ScrollView centered-state tappable [0,283][1080,2400]
android.view.ViewGroup centered-state-content tappable [0,967][1080,1433]
android.widget.TextView Connect a provider tappable [362,1132][718,1197]
android.widget.TextView Connect GitHub to start a manual review of a pull request. tappable [114,1206][966,1252]
android.widget.Button Connect GitHub tappable [55,1317][1025,1433]
android.widget.TextView Connect GitHub tappable [422,1351][656,1397]
android.view.View Home, tab, 1 of 3 tappable [0,2195][360,2337]
android.widget.TextView HOME tappable [13,2281][347,2320]
android.view.View Agents, tab, 2 of 3 tappable [360,2195][720,2337]
android.widget.TextView AGENTS tappable [373,2281][707,2320]
android.view.View Profile, tab, 3 of 3 tappable [720,2195][1080,2337]
android.widget.TextView PROFILE tappable [733,2281][1067,2320]
/home/igor_kilocode_ai/.local/share/kwf/sections/explorer-manual-review-connect-provider-the-connect-githu-2f462-d2c6/e2e-mobile-app/e2-connect.log
SCENE e2 OK
android.widget.LinearLayout com.kilocode.kiloapp:id/action_bar_root tappable [0,0][1080,2400]
android.widget.FrameLayout android:id/content tappable [0,0][1080,2400]
android.widget.Button Go back tappable [0,149][101,250]
android.view.View PR Review tappable [111,167][1044,232]
android.widget.ScrollView centered-state tappable [0,278][1080,2400]
android.view.ViewGroup centered-state-content tappable [0,968][1080,1433]
android.widget.TextView Connect GitHub tappable [391,1133][689,1198]
android.widget.TextView Connect your GitHub account to review pull requests on mobile. tappable [72,1207][1009,1253]
android.widget.Button Connect GitHub tappable [55,1318][1025,1433]
android.widget.TextView Connect GitHub tappable [450,1352][684,1398]
Owner request

Explorer finding: manual-review-connect-provider: The "Connect GitHub" primary action is a small centered pill here but full-width on the near-identical PR Review connect screen, so the same action is not styled the same.

The user-agent explorer found this while using the app like a user.
One finding per item; the explorer never edits product code.

Flow: manual-review-connect-provider
Found on revision: fd04ca1

Repro:

  1. set this state first: a wiped install on a brand-new account
  2. open the app on emulator-5602
  3. reach the screen the capture names (manual-review-connect-provider)
  4. the capture shows the defect named below

Observed: The "Connect GitHub" primary action is a small centered pill here but full-width on the near-identical PR Review connect screen, so the same action is not styled the same.
Expected: the screen renders without this defect

Evidence (from the device run):

Follow-ups (not changed here)

  • not proved live: On a fresh account with no GitHub or GitLab connection, open Code Reviewer → Manual review: the "Connect GitHub" primary action spans the available width, identical to the PR-review connect screen, instead of a small centered pill. (no capture cited it)
  • not proved live: Open a PR-review detail route that gates on GitHub with no connection: its "Connect GitHub" CTA is still full-width, so both connect screens render the same action the same way. (no capture cited it)

Open findings (not fixed here)

  • not proved live: manual-review-connect-provider.png is no longer on the host that took it, so no publish can carry it

Comment thread apps/mobile/src/components/code-reviewer/manual-review-screen.tsx
@kilo-code-bot

kilo-code-bot Bot commented Sep 19, 2026

Copy link
Copy Markdown
Contributor

Code Review Summary

Status: 1 Issue Found | Recommendation: Address before merge

Overview

Severity Count
CRITICAL 0
WARNING 0
SUGGESTION 1
Issue Details (click to expand)

SUGGESTION

File Line Issue
apps/mobile/src/components/code-reviewer/manual-review-screen.tsx 159 Added four-line rationale comment documents a one-line class change, against the repo's no-comments convention; it also overstates the match since ProviderConnectCard uses w-full without mt-3.
Files Reviewed (2 files)
  • apps/mobile/src/components/code-reviewer/manual-review-screen.tsx - 1 issue
  • apps/mobile/src/components/code-reviewer/manual-review-screen.mounted.test.tsx - 0 issues

Fix these issues in Kilo Cloud

Previous Review Summary (commit 2f5ea8b)

Current summary above is authoritative. Previous snapshots are kept for context only.

Previous review (commit 2f5ea8b)

Status: 1 Issue Found | Recommendation: Address before merge

Overview

Severity Count
CRITICAL 0
WARNING 0
SUGGESTION 1
Issue Details (click to expand)

SUGGESTION

File Line Issue
apps/mobile/src/components/code-reviewer/manual-review-screen.tsx 159 Added four-line rationale comment documents a one-line class change, against the repo's no-comments convention; it also overstates the match since ProviderConnectCard uses w-full without mt-3.
Files Reviewed (2 files)
  • apps/mobile/src/components/code-reviewer/manual-review-screen.tsx - 1 issue
  • apps/mobile/src/components/code-reviewer/manual-review-screen.mounted.test.tsx - 0 issues

Fix these issues in Kilo Cloud


Reviewed by deepseek-v4.1-flash · Input: 0 · Output: 0 · Cached: 0

Review guidance: REVIEW.md from base branch main

…creen

Explorer finding: manual-review-connect-provider: The "Connect GitHub" primary action is a small centered pill here but full-width on the near-identical PR Review connect screen, so the same action is not styled the same.

The user-agent explorer found this while using the app like a user.
One finding per item; the explorer never edits product code.

Flow: manual-review-connect-provider
Found on revision: fd04ca1

Repro:
1. set this state first: a wiped install on a brand-new account
2. open the app on emulator-5602
3. reach the screen the capture names (manual-review-connect-provider)
4. the capture shows the defect named below

Observed: The "Connect GitHub" primary action is a small centered pill here but full-width on the near-identical PR Review connect screen, so the same action is not styled the same.
Expected: the screen renders without this defect

Evidence (from the device run):
- ~/.local/share/kwf/findings/explorer-manual-review-connect-provider-the-connect-githu-2f462e15/manual-review-connect-provider.png
@iscekic
iscekic force-pushed the kwf/explorer-manual-review-connect-provider-the-connect-githu-2f462-d2c6 branch from 2f5ea8b to eab6731 Compare September 19, 2026 03:55
@iscekic iscekic changed the title fix(mobile): make manual-review Connect GitHub action full-width fix(mobile): make Connect GitHub action full-width on manual review screen Sep 19, 2026
@iscekic
iscekic marked this pull request as draft September 19, 2026 03:58
@iscekic
iscekic marked this pull request as ready for review September 19, 2026 04:05
@iscekic

iscekic commented Sep 19, 2026

Copy link
Copy Markdown
Collaborator Author

This description names a scenario the proof did not capture:

  • not proved live: On a fresh account with no GitHub or GitLab connection, open Code Reviewer → Manual review: the "Connect GitHub" primary action spans the available width, identical to the PR-review connect screen, instead of a small centered pill. (no capture cited it)

A repeated proof run rebuilds the same evidence, so no proof run is dispatched for a named gap. Merging with this gap open is your decision.

@iscekic
iscekic requested a review from eshurakov September 19, 2026 04:27
@iscekic iscekic added the human-ready The PR is ready for human review. label Sep 19, 2026
@iscekic
iscekic requested a review from pandemicsyn September 19, 2026 04:27
@iscekic iscekic self-assigned this Sep 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

human-ready The PR is ready for human review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant