Add UI support for KHR_materials_retroreflection - #667
Open
mklefrancois wants to merge 1 commit into
Open
Conversation
Adds a "Retroreflection" toggle switch and "Retroreflection Strength" debug output channel in Advanced Controls, following the same pattern as the other KHR_materials_* extension toggles. Bumps the glTF-Sample-Renderer submodule to the commit implementing the extension.
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds UI support for
KHR_materials_retroreflection, implemented in the companion renderer PR KhronosGroup/glTF-Sample-Renderer#50 (please review/merge that one first).KHR_materials_*extension toggles.glTF-Sample-Renderersubmodule to the commit implementing the extension.Closes #664.
Test plan
npm run buildsucceeds