Skip to content

Add test for KHR_node_visibility - #244

Merged
javagl merged 6 commits into
KhronosGroup:mainfrom
javagl:add-node-visibility-test
Aug 21, 2026
Merged

Add test for KHR_node_visibility#244
javagl merged 6 commits into
KhronosGroup:mainfrom
javagl:add-node-visibility-test

Conversation

@javagl

@javagl javagl commented Nov 3, 2025

Copy link
Copy Markdown
Contributor

An asset for testing the KHR_node_visibility extension.

A first version of this was posted in a comment in the pull request. A version with minor additions was posted in a later comment. It could make sense to add this as a dedicated test asset for the extension here.

The asset uses some nested node structure to display the messages and support status. A summary:

  • First row:

    • There is a label that says "The extension is supported"
    • Slightly in front of that, there is a label that says "The extension is not supported"
    • The label in the front has the extension with visible:false. So when the extension is supported, this is not shown.
  • Second row:

    • There is a label that says "Does not handle defaults properly"
    • Slightly in front of that, there is a label that says "Does handle defaults properly"
    • The label in the front has visible:undefined, which should default to true. So when the default is handled properly, then this is shown.
  • Third row:

    • There are two labels that say "Does not properly handle hierarchy".
    • These are the leaves of a chain of nodes with visbility flags false, false, true and true, true, false, respectively.
    • So they should eventually both not be visible.

(There are some blank rectangles that hide the implementation messages when the extension is not supported at all).

Direct preview to the README body: https://github.com/javagl/glTF-Sample-Assets/blob/add-node-visibility-test/Models/NodeVisibilityTest/README.body.md

@javagl
javagl requested a review from bghgary August 21, 2026 15:52
@javagl

javagl commented Aug 21, 2026

Copy link
Copy Markdown
Contributor Author

@bghgary I had seen the 🎉 , but maybe you want to have another look at this to see whether it can be merged. I've tried it out in the Sample Viewer and BabylonJS, and ... that's nearly boring, because they both support the extension. But I've used the BabylonJS "Scene Explorer" for mimicking the forms of "wrong behavior" that are covered via the screenshots in https://github.com/javagl/glTF-Sample-Assets/blob/add-node-visibility-test/Models/NodeVisibilityTest/README.body.md , and hope that this all makes sense now.

@bghgary bghgary left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Reviewed by Copilot on behalf of @bghgary]

LGTM except for one minor comment.

Comment thread Models/NodeVisibilityTest/metadata.json Outdated
@javagl
javagl merged commit 688d653 into KhronosGroup:main Aug 21, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants