Skip to content

Add test for WebGL background clear after readback crash #3786

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
lizeb-google wants to merge 1 commit into from
Closed

Add test for WebGL background clear after readback crash #3786

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions sdk/tests/conformance/canvas/00_test_list.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,4 +18,5 @@ drawingbuffer-test.html
--min-version 1.0.4 to-data-url-after-composite.html
viewport-unchanged-upon-resize.html
--min-version 1.0.4 webgl-to-2d-canvas.html
--min-version 1.0.4 webgl-background-clear-after-present-crash.html

73 changes: 73 additions & 0 deletions sdk/tests/conformance/canvas/webgl-background-clear-after-present-crash.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,73 @@
<!--
Copyright (c) 2026 The Khronos Group Inc.
Use of this source code is governed by an MIT-style license that can be
found in the LICENSE.txt file.
-->
<!DOCTYPE html>
<html>
<head>
<meta charset="utf-8">
<title>WebGL background clear after readback does not crash</title>
<link rel="stylesheet" href="../../resources/js-test-style.css"/>
<script src="../../js/js-test-pre.js"></script>
<script src="../../js/webgl-test-utils.js"></script>
</head>
<body>
<canvas id="canvas" width="100" height="100"></canvas>
<div id="description"></div>
<div id="console"></div>
<script type="application/javascript">
"use strict";

description("Verifies that calling gl.clear() while the page is hidden after toDataURL() does not cause a crash when preserveDrawingBuffer is false.");

const wtu = WebGLTestUtils;
const canvas = document.getElementById("canvas");
const gl = wtu.create3DContext(canvas, { preserveDrawingBuffer: false });

if (!gl) {
testFailed("WebGL context should be initialized successfully");
} else {
// 1. Initial draw & clear
gl.clearColor(1.0, 0.0, 0.0, 1.0);
gl.clear(gl.COLOR_BUFFER_BIT);

// 2. Wait for composite so the frame is presented to the compositor.
wtu.waitForComposite(() => {
// 3. Perform a readback/toDataURL.
canvas.toDataURL();

const onVisibilityChange = () => {
if (document.visibilityState === 'hidden') {
// 5. Page is hidden. Call gl.clear().
gl.clearColor(0.0, 1.0, 0.0, 1.0);
gl.clear(gl.COLOR_BUFFER_BIT);
wtu.glErrorShouldBe(gl, gl.NO_ERROR, "gl.clear in background should not produce GL errors");

// Restore page visibility
if (window.testRunner && window.testRunner.setMainWindowHidden) {
testRunner.setMainWindowHidden(false);
}
} else if (document.visibilityState === 'visible') {
document.removeEventListener('visibilitychange', onVisibilityChange);
testPassed("WebGL clear while page is hidden completed without crashing");
finishTest();
}
};

document.addEventListener('visibilitychange', onVisibilityChange);

// 4. Hide the page programmatically if testRunner is present
if (window.testRunner && window.testRunner.setMainWindowHidden) {
testRunner.setMainWindowHidden(true);
} else {
testPassed("Test complete (window.testRunner not available to hide window)");
finishTest();
}
});
}

var successfullyParsed = true;
</script>
</body>
</html>
Loading