Repository navigation
Remove unused prost-build dependency - #141
Closed
ValarDragon wants to merge 1 commit into
Closed
ValarDragon wants to merge 1 commit into
ValarDragon wants to merge 1 commit into
Conversation
Author
|
duplicate of 142 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ur-registrydeclaresprost-buildas a build dependency even though it has no build script and its protobuf bindings are checked into the repository. Downstream callers therefore pull in protobuf generation tooling that is never used.Remove the unused build dependency and prune the 14 packages that become unreachable from the workspace lockfile. No remaining dependency versions, Rust APIs, or wire formats change.
Validation:
cargo +1.97.1 test -p ur-registry --no-default-features --features std --locked --offline -- --quiet— 161 tests passed.git diff --check— passed.