Added pam rest message and protobuf dependency for sdk. - #240
Open
ukumar-ks wants to merge 2 commits into
Open
Conversation
ukumar-ks
requested review from
THeflinKeeper,
saldoukhov and
tylerccarson
as code owners
August 17, 2026 12:05
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
| export const removeControllerMessage = ( | ||
| data: PAM.IPAMGenericUidRequest | ||
| ): RestMessage<PAM.IPAMGenericUidRequest, PAM.IPAMRemoveControllerResponse> => | ||
| createMessage(data, 'pam/remove_controller', PAM.PAMGenericUidRequest, PAM.PAMRemoveControllerResponse) |
Contributor
There was a problem hiding this comment.
mismatch / typos with the request type here-- it's actually plural, so PamGenericUidsRequest
| "@keeper-security/keeperapi": "18.1.0", | ||
| "ts-node": "^10.7.0", | ||
| "asmcrypto.js": "^2.3.2", | ||
| "protobufjs": "^7.6.5", |
Contributor
There was a problem hiding this comment.
curious why you need to add protobufjs as an explicit dependency here-- keeperapi already implicitly installs it as a dependency of KeeperSdk
Contributor
Author
There was a problem hiding this comment.
In KeeperApi 'protobufjs' is only in devDependencies, so it isn’t installed for consumers, causing KeeperSdk and SDK examples to fail with Cannot find module 'protobufjs/minimal'.
ukumar-ks
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.