Repository navigation
fix(ci): write boot metrics file at repo root on main - #4467
Merged
Merged
Conversation
Co-authored-by: Tyler Dane <tyler-dane@users.noreply.github.com>
tyler-dane
added
the
agent-automerge
Cursor
tyler-dane
marked this pull request as ready for review
October 14, 2026 19:48
tyler-dane
enabled auto-merge
October 14, 2026 19:48
Contributor
|
Boot bundle: 507.6 KB gzip (+0.0 KB vs main) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
The Boot bundle workflow's main push step sets
COMPASS_BOOT_SIZE_METRICS_FILE=boot-main-metrics.jsonandcats that path from the repo root, butrun-boot-size-check.shruns the build fromapps/calendar-web, so Bun wrote the file there instead. The build succeeded and the log line was printed, thencatfailed and took down thedeltaandboot-bundlejobs (see run https://github.com/KeepSoftwareSimple/compass-calendar/actions/runs/38622516707).PR delta was unaffected because
pr-boot-size-delta.tsalready passes absolute metrics paths.This change resolves relative
COMPASS_BOOT_SIZE_METRICS_FILEvalues against the repo root before changing intoapps/calendar-web, so main measurement stays informational and passes.Verify
Local: ran
run-boot-size-check.shwithCOMPASS_BOOT_SIZE_METRICS_FILE=boot-main-metrics.json; metrics JSON appears at repo root.