Conversation
mducducd
force-pushed
the
dev/prebuilt-flash-att
branch
2 times, most recently
from
3ee7f46 to
1738abf
Compare
FWao
requested changes
May 7, 2026
Member
There was a problem hiding this comment.
@mducducd Please update the main README regarding this as a build is no longer necessary. Maybe we can leave an advanced / troubleshooting section on the bottom to explain if there are errors / the user wants different version, how the user could switch back to self-built flash-attn.
Otherwise looks good, I tested on a DGX Spark.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Set up installation with pre-built wheels for flash_attn 2.8.3 for x86_64 and aarch64. Installation now takes less than 10min then we can consider putting it in
--extra gpuWheels are taken from: https://github.com/mjun0812/flash-attention-prebuild-wheels
Tests have been successful on Planets but failed with Github. I hard-code
--extra cpuin build.yml