Repository navigation
feat: ADB version tracking and release workflow docs - #4
Merged
Merged
Conversation
Moves the ADB binary extraction target from %TEMP%/amc-adb-bin to the user's app-data directory (%LOCALAPPDATA%\AMC\adb on Windows, ~/Library/Application Support/AMC/adb on macOS, ~/.local/share/AMC/adb on Linux). This reduces antivirus false positives, survives disk-cleanup runs, and keeps the ADB daemon path stable across sessions. Also captures the bundled ADB version string to bin/adb-version.txt during npm run setup, so the release workflow can surface it in the GitHub release notes. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…e flow - adbPath.ts now compares the bundled bin/adb-version.txt against a stamp in the app-data extract dir; re-extracts on version mismatch so end users automatically get a newer ADB after an app update - package.json bumped to 0.4.0 (post-release master convention) - README: documents how to update the bundled ADB and the release versioning workflow (master always one version ahead of latest release) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
src/adbPath.ts— ADB extraction now compares the version bundled at build time (bin/adb-version.txt) against a stamp written alongside the extracted binary. If they differ, the binary is re-extracted. This means end users automatically get an updated ADB after installing a new app version, instead of silently reusing a stale binary.package.json— bumped to0.4.0to follow the new convention: master always carries a version one step ahead of the latest release (v0.3.0was the last release).README.md— added two new developer sections:bin/must be deleted before re-running setup to force a fresh download.