Eisenstadt#13
Merged
Merged
Conversation
Eisenstadt ships only an engine HDF5 template (no station CSVs like Wien/ Bad Aussee). Add prepare_eisenstadt_swmm_timeseries.R to extract the rain (/Kurven/Regen) and ET0 (/Kurven/ET0) curves from an engine .h5 and write SWMM-5 external time-series files, plus pre-generated files for the bundled eisenstadt-2005 template under inst/extdata/models/eisenstadt-2005/swmm/. Key finding documented in the swmm/README.md: the engine stores both curves as RATES in mm/h on an hour-based axis. Rain is only sane as mm/h (657 mm/a; mm-per-interval would be 3943 mm/a), and the Wien vignette explicitly does value/period to reach mm/h. The exporter therefore converts rain to mm per interval and ET0 to mm/day for SWMM. Consequence: a daily ET0 (mm/d) written into /Kurven/ET0 without /24 is integrated by the kernel as mm/h -> 24x too high. The Eisenstadt template ET0 is a constant 0.2 mm/h (=4.8 mm/d) placeholder, not a measured series.
The Eisenstadt standard rain is already correct in mm/h and is used by the kernel as-is. Ship the rain additionally as native mm/h intensities (eisenstadt_rain_mmh.dat) next to the mm-per-interval VOLUME file, add a rain_format = 'intensity' option to the exporter, and clarify in the README that rain is not the unit issue (only ET0 is).
The engine reads //Kurven/ET0 as a mm/h rate (same hour-based convention as //Kurven/Regen), but example_wien_minimal.Rmd wrote the daily ET0 values (mm/day) straight into the curve while rain got the symmetric value/period scaling. The kernel therefore integrated ET0 24x too high, inflating the modelled ET share. Divide ET0 by its interval in hours before writing the curve, and update the timeseries-info summary to label ET0 as mm/h and recover its total via value*period_h (total_mm is unchanged).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.