Fixes to default values and comments#63
Open
Starstrider42 wants to merge 3 commits into
Open
Conversation
The curve went from 1.0 to 5.0 before dropping to 0. All the explicit instrument curves had 0.5 instead, and this makes more sense than supposing an atmosphere enhances observation quality.
The original value, 0.01 t/m^3, prevented the included gas analyzer from working at all (it's a partial density of 8.2 Earth atmospheres). Assuming this was meant to be 1% of Earth's atmosphere, I've changed it to 1e-5 t/m^3 (0.8% Earth's sea level density) and documented the non-obvious units.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a number of typos and copy-paste errors I came across while trying to understand the code. They include a bug that makes it effectively impossible for local scanners to operate unless they override
LocalThreshold.