Release 2.3.7

GameData/DynamicBatteryStorage/DynamicBatteryStorageSettings.cfg

@@ -946,7 +946,7 @@ DYNAMICBATTERYSTORAGE
       // Field to poll in editor
       editorFieldName = CurrentElectricalGeneration
       // Field to poll in flight
-      flightFieldName = MaximumElectricalGeneration
+      flightFieldName = MaxElectricalGeneration
       // Multiply the output by these if you need to. Convention is that a consumer is negative.
       editorValueScalar = 1.0
       flightValueScalar = 1.0

GameData/DynamicBatteryStorage/Versioning/DynamicBatteryStorage.version

@@ -6,7 +6,7 @@
     {
         "MAJOR":2,
         "MINOR":3,
-        "PATCH":6,
+        "PATCH":7,
         "BUILD":0
     },
     "KSP_VERSION":

Source/DynamicBatteryStorage/UI/SystemsMonitorUI.cs

@@ -243,7 +243,7 @@ protected void OnGUIAppLauncherReady()
       showWindow = false;
 
       Utils.Log("[SystemsMonitorUI]: App Launcher Ready", Utils.LogType.UI);
-      if (ApplicationLauncher.Ready && stockToolbarButton == null)
+      if (ApplicationLauncher.Ready && stockToolbarButton == null && Settings.Enabled)
       {
         if (HighLogic.LoadedSceneIsFlight || HighLogic.LoadedSceneIsEditor)
           stockToolbarButton = ApplicationLauncher.Instance.AddModApplication(
@@ -293,7 +293,7 @@ public void ResetAppLauncher()
 
       Utils.Log("[SystemsMonitorUI]: Reset App Launcher", Utils.LogType.UI);
       FindData();
-      if (stockToolbarButton == null)
+      if (stockToolbarButton == null && Settings.Enabled)
       {
         stockToolbarButton = ApplicationLauncher.Instance.AddModApplication(
               OnToolbarButtonOn,

Source/DynamicBatteryStorage/UI/ToolbarAdvanced.cs

@@ -121,17 +121,25 @@ public void Initialize(Transform root, ToolbarPanel parentPanel)
       constantOnButton.onClick.AddListener(delegate { SetConstantState(true); });
 
       userConsumptionInput.contentType = InputField.ContentType.DecimalNumber;
+      userConsumptionInput.characterValidation = InputField.CharacterValidation.Decimal;
       userConsumptionInput.onValueChanged.AddListener(delegate { OnManualGenerationChange(); });
       userGenerationInput.contentType = InputField.ContentType.DecimalNumber;
+      userGenerationInput.characterValidation = InputField.CharacterValidation.Decimal;
       userGenerationInput.onValueChanged.AddListener(delegate { OnManualGenerationChange(); });
 
+
       SectionEnabled = false;
       advancedObject.SetActive(false);
       dbsObject.SetActive(false);
       Localize();
-      
+
       SetupTooltips(root, Tooltips.FindTextTooltipPrefab());
     }
+    protected void OnDestroy()
+    {
+
+      InputLockManager.RemoveControlLock("DBSFocus");
+    }
     protected void Localize()
     {
       headerText.text = Localizer.Format("#LOC_DynamicBatteryStorage_AdvancedPanel_AdvancedTitle");
@@ -189,6 +197,22 @@ public void Update(VesselElectricalData data)
     protected void UpdateAdvanced()
     {
       /// what, all event driven? you monster
+      if (userGenerationInput.isFocused || userConsumptionInput
+        .isFocused)
+      {
+        if (InputLockManager.IsUnlocked(ControlTypes.KEYBOARDINPUT))
+        {
+          InputLockManager.SetControlLock(ControlTypes.KEYBOARDINPUT, "DBSFocus");
+        }
+
+      }
+      else
+      {
+        if (InputLockManager.IsLocked(ControlTypes.KEYBOARDINPUT))
+        {
+          InputLockManager.RemoveControlLock("DBSFocus");
+        }
+      }
     }
     protected void UpdateDBS()
     {
@@ -269,7 +293,22 @@ public void SetTabState(bool state)
     }
     public void OnManualGenerationChange()
     {
-      mainPanel.PowerUI.SetManualPowerInputs(float.Parse(userGenerationInput.text), float.Parse(userConsumptionInput.text));
+
+
+      mainPanel.PowerUI.SetManualPowerInputs(
+        ValidateManualInput(userGenerationInput),
+        ValidateManualInput(userConsumptionInput));
+    }
+
+    protected float ValidateManualInput(InputField handler)
+    {
+      string input = handler.text;
+
+      if (!float.TryParse(input, out float result))
+      {
+        result = 0f;
+      }
+      return result;
     }
     public void SetConstantState(bool state)
     {

Source/DynamicBatteryStorage/UI/ToolbarPower.cs

@@ -136,8 +136,14 @@ protected void UpdatePowerFlowAndBatteryFields(VesselElectricalData data)
       double netPower = data.CurrentConsumption + data.GetSimulatedElectricalProdution() + userGeneration - userConsumption;
       data.GetElectricalChargeLevels(out double EC, out double maxEC);
 
-
-      batteryText.text = String.Format("{0:F0} / {1:F0} ({2:F1}%)", EC, maxEC, EC / maxEC * 100d);
+      if (maxEC > 0)
+      {
+        batteryText.text = String.Format("{0:F0} / {1:F0} ({2:F1}%)", EC, maxEC, EC / maxEC * 100d);
+      }
+      else
+      {
+        batteryText.text = "-";
+      }
       if (EC <= 0.001)
       {
         batteryText.color = colorBadText;

Source/DynamicBatteryStorage/UI/ToolbarSituation.cs

@@ -298,7 +298,7 @@ protected double CalculateOcclusionTime(CelestialBody body, double bodyOrbitHeig
     {
       if (bodyOrbitHeight == 0d)
       {
-        return body.rotationPeriod;
+        return body.rotationPeriod /2d;
 
       }
       else

changelog.txt

@@ -1,3 +1,12 @@
+v2.3.7
+------
+- Fixed a config issue that stopped fission reactors being measured in flight
+- Added input locking to the advanced generation/consumption text fields
+- Added input validation to the advanced generation/consumption text fields
+- Fixed NaN displayed when vessel maximum power is 0
+- Fixed missing divide by two in dark time calculation at the surface of bodies
+- SM window will now disable itself when Kerbalism is enabled as well as the rest of the mod
+
 v2.3.6
 ------
 - Changed how fission reactors are measured in-flight so they don't result in miscalculation of vessel generation (requires latest SH version)

readme.txt

@@ -1,5 +1,5 @@
 ==============================
-Dynamic Battery Storage v2.3.6
+Dynamic Battery Storage v2.3.7
 ==============================
 
 A small utility mod for Kerbal Space Program, intended to support my other projects. Effectively required by Near Future Electrical, CryoEngines, KerballAtomics and CryoTanks.