Repository navigation
Conversation
…d fits but never one
…mator outputs, never data for a missing name
…ata with r frozen to 0 and its summary
…ut DataFrame.eval's index copy
…istograms, not one search per variable and process
…he Minuit one is forced positive definite with degenerate normalisations
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds the functions that the bbtautau v6 analysis uses. It also corrects the ML export and makes the evaluation of expressions faster.
New functions
FriendConfig.channels: ShapeSmith reads a friend only in the listed channels. The default is all channels. A channel without this friend production does not look for the friend files.Analysis.control_channels:datacardsandfitadd the control channels to each final state. A control channel is never a final state of its own. Example: em as the ttbar control channel of the tau channels.targetofDataMinusandABCD: the estimator writes its output to this region. The default is the nominal region. Example: QCD in a diagnostic region.shapesmith fit --background-only: this command fits the data with r set to 0 and frozen (combine -M FitDiagnostics). It writesdatacards/background_fit.{json,md}. The summary shows the fit status, the pull and constraint of eachnuisance, and the prefit and postfit yields.
Corrections
ml-exportdoes not export the control channels.--cminDefaultMinimizerStrategy 0 --robustHesse 1. Before, Minuit forced the covariance to be positive definite when normalisations were degenerate. The fit then showed uncertainties that were too small.Performance
expressions.evaluategives only the columns of the expression topd.eval. Before,DataFrame.evalcopied the index on each call. This copy used 90–95 % of the run time.estimatefinds the inputs ofDataMinusin one pass over the histograms. Before, it did one search for each variable and process.sm2018_binned_v6, the fake-factor measurement takes 28 min instead of 180 min.estimatetakes 9 min instead of approximately 45 min.