Cran/resubmission 1.4.0 - #7
Merged
Merged
Conversation
…ver 5 seconds to test all DIA options chains.
…ver 5 seconds to test all DIA options chains.
…umentation. Clarified example in covert.log. refactored allticks2sec and imroved the call to dopar in case back end isn't registered.
…t updates/fixes so make this test informal for now.
Review/cran 1.4.1 fixes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a resubmission of FinancialInstrument 1.4.1 addressing the feedback received following the 1.4.0 submission addressing issue #3
The following changes were made:
ls_by_currency.FinancialInstrument:::.instrumentfrom documentation examples.expires()and restored the previously exportedrm_by_currency()function.\dontrun{}wrappers with executable examples or\donttest{}for examples requiring external services.Tick2Secprogress output suppressible with a trailingverbose = FALSEargument.alltick2sec().FinancialInstrument provides general infrastructure for financial-instrument metadata and does not implement a methodology associated with a specific publication. Therefore, no DOI, ISBN, or methodological reference applies.
Ross Bennett, the previous maintainer, agreed to the maintainer transition and provided confirmation directly to CRAN.
R CMD check results:
0 errors | 0 warnings | 1 note
The remaining NOTE reports that FinancialInstrument was previously archived on CRAN and is expected for this resubmission.