Skip to content

Cran/resubmission 1.4.0 - #7

Merged
JustinMShea merged 38 commits into
masterfrom
cran/resubmission-1.4.0
Jul 24, 2026
Merged

Cran/resubmission 1.4.0#7
JustinMShea merged 38 commits into
masterfrom
cran/resubmission-1.4.0

Conversation

@JustinMShea

Copy link
Copy Markdown
Owner

This is a resubmission of FinancialInstrument 1.4.1 addressing the feedback received following the 1.4.0 submission addressing issue #3

The following changes were made:

  • Corrected the unexecutable example in ls_by_currency.
  • Added missing return-value documentation, including output classes, structures, meanings, and side-effect-only functions.
  • Removed use of FinancialInstrument:::.instrument from documentation examples.
  • Exported expires() and restored the previously exported rm_by_currency() function.
  • Removed commented-out executable alternatives from examples.
  • Replaced unnecessary \dontrun{} wrappers with executable examples or \donttest{} for examples requiring external services.
  • Updated examples and tests that write files to use temporary locations and clean up afterward.
  • Made Tick2Sec progress output suppressible with a trailing verbose = FALSE argument.
  • Removed the fixed home-directory defaults from alltick2sec().
  • Added regression tests for instrument saving, loading, registry restoration, and currency-based removal.
  • Checked compatibility with blotter and quantstrat. The existing quantstrat test failures were reproduced identically with both the previous and updated FinancialInstrument versions and were therefore not introduced by this submission.

FinancialInstrument provides general infrastructure for financial-instrument metadata and does not implement a methodology associated with a specific publication. Therefore, no DOI, ISBN, or methodological reference applies.

Ross Bennett, the previous maintainer, agreed to the maintainer transition and provided confirmation directly to CRAN.

R CMD check results:

0 errors | 0 warnings | 1 note

The remaining NOTE reports that FinancialInstrument was previously archived on CRAN and is expected for this resubmission.

JustinMShea and others added 30 commits July 22, 2026 23:56
…ver 5 seconds to test all DIA options chains.
…ver 5 seconds to test all DIA options chains.
…umentation. Clarified example in covert.log. refactored allticks2sec and imroved the call to dopar in case back end isn't registered.
…t updates/fixes so make this test informal for now.
@JustinMShea
JustinMShea merged commit a2d457a into master Jul 24, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants