Core: oxc formatter + bump all deps to latest#103
Merged
Conversation
Migrate the formatter from Biome to oxc (oxfmt + oxlint), matching gjsify's own tooling (gjsify moved off Biome in 0.4.29). Add .oxfmtrc.json + .oxlintrc.json configured to Learn6502's existing style (2-space, double quotes, es5 — an engine swap, not a restyle); drop biome.json + @biomejs/biome; add oxfmt + oxlint devDeps. `format` → `gjsify format --write` (oxc reports by default), + `lint`/`check:lint` scripts + a CI Lint step. CSS/JSON formatting is dropped (oxfmt does JS/TS only). 81 files reformatted + auto-fixed (incl. import-type conversions). Fixed 4 real correctness errors (useless escapes, new Array(), interface-extends-Object, arguments-shadowing); configured no-unused-expressions allowShortCircuit and triple-slash-reference off for the legitimate `DEV_LOG && log()` and NS ambient .d.ts patterns rather than silencing them. Bump ALL deps to latest via `gjsify upgrade --latest` (all patch/minor/prerelease, no majors): @nativescript/core 9.0.20, @girs/* rc.13→4.0.4, tailwindcss 4.3.0, @gjsify/* 0.4.37, @types/node, postcss, etc. + aligned 2 inconsistent ranges. Validated: check:format + lint + type-check green across all workspaces; learn + examples builds pass. app-android on-device re-validation (NS + Tailwind bump) is a follow-up.
The @girs/* bump to the 4.0.4 prerelease broke deduplication — a nested @girs/gjs under @girs/gobject-2.0 duplicated the ambient gjs.d.ts globals (TS2300/TS2451/TS6200), failing app-gnome's type-check in CI's clean --immutable install (it passed locally only because of a deduped node_modules). @Girs 'latest' is an unstable prerelease; keep them at main's resolution while all other deps stay bumped to latest.
The previous commit wrongly git-rm'd @Girs 4.0.4 cache zips that main's lockfile references transitively (via @girs/gjs) — keep them committed for zero-install.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modernizes Learn6502's tooling to match gjsify, and brings every dependency to latest.
Formatter: Biome → oxc
gjsify moved its own
format/lint/fixoff Biome to oxc (oxfmt + oxlint) in 0.4.29; Learn6502 was pinned to the old@gjsify/cli@0.4.14(Biome). This bumps the CLI and switches engines:.oxfmtrc.json+.oxlintrc.json, configured to Learn6502's existing style (2-space, double quotes, es5) — an engine swap, not a restyle.biome.json+@biomejs/biome; addoxfmt+oxlintdevDeps.format→gjsify format --write(oxc reports by default); addlint/check:lintscripts + a CI Lint step.import typeconversions). Fixed 4 real correctness errors; for the legitimateDEV_LOG && log()and NS ambient-.d.tspatterns, configuredno-unused-expressions: allowShortCircuit+triple-slash-reference: offrather than silencing.Dependencies → latest
gjsify upgrade --latestacross all 7 package.json (all patch/minor/prerelease, no majors):@nativescript/core9.0.20,@girs/*rc.13→4.0.4,tailwindcss4.3.0,@gjsify/*0.4.37,@types/node,postcss, … + aligned 2 inconsistent ranges.Validation
check:format+lint+tscgreen across all workspaces;learn+examplesbuilds pass.Follow-up: app-android needs an on-device re-validation (the NS + Tailwind bumps) — type-check + Vite build pass, but the emulator render wasn't re-run in this PR.