Split test history code into separate module - #194
Merged
Merged
Conversation
christiangnrd
force-pushed
the
splithist
branch
2 times, most recently
from
September 20, 2026 21:37
85bbe23 to
8eb3eca
Compare
christiangnrd
added this pull request to stack #196
September 20, 2026 21:39
giordano
reviewed
Sep 20, 2026
giordano
left a comment
giordano
left a comment
Collaborator
There was a problem hiding this comment.
Sorry, I'm going to be pesky about style nits
Comment on lines
+2
to
+4
| using Scratch | ||
| using Serialization | ||
| using FileWatching: Pidfile |
Collaborator
There was a problem hiding this comment.
Not a fan of indenting inside module
| using Serialization | ||
| using FileWatching: Pidfile | ||
|
|
||
| import ..ParallelTestRunner: AbstractTestRecord, anynonpass, Lockable |
Collaborator
There was a problem hiding this comment.
Also, not a fan at all of import, it's spooky action at a distance.
Suggested change
| import ..ParallelTestRunner: AbstractTestRecord, anynonpass, Lockable | |
| using ..ParallelTestRunner: ParallelTestRunner |
or
Suggested change
| import ..ParallelTestRunner: AbstractTestRecord, anynonpass, Lockable | |
| import ..ParallelTestRunner |
if you prefer (I'm just allergic to the import keyword), and explicitly qualify method extensions below
Collaborator
Author
There was a problem hiding this comment.
I went with
import ..ParallelTestRunner as PTRbut if you'd rather I do one of your suggestions I'm happy to change it
Merged
christiangnrd
force-pushed
the
splithist
branch
from
September 21, 2026 01:00
8eb3eca to
c3dd32f
Compare
giordano
approved these changes
Sep 21, 2026
christiangnrd
force-pushed
the
splithist
branch
from
September 21, 2026 01:06
c3dd32f to
e2af6eb
Compare
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
christiangnrd
force-pushed
the
splithist
branch
from
September 21, 2026 01:14
e2af6eb to
5d8f9f9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(DO NOT SQUASH)
Also fix test that passed on retry being recorded as a failure.