Repository navigation
Add Aqua.jl to CI - #167
Merged
Merged
Conversation
- Drop exports of names that were never defined (SparseArrayCompat, hvcat!, BinaryOps.BinaryOp, BinaryOps.fmod). - Add compat entries for the stdlib dependencies. - Ambiguities are skipped (many pre-existing) and the two unbound-parameter defaultfill methods are marked broken. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## v11 #167 +/- ##
==========================================
+ Coverage 67.23% 67.38% +0.14%
==========================================
Files 54 54
Lines 4465 4485 +20
==========================================
+ Hits 3002 3022 +20
Misses 1463 1463 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
defaultfill(::Type{Union{T, Nothing}}) where T (and the Missing variant) left T
unbound and returned the type T instead of a value. The generic method now
strips Nothing/Missing and returns zero of the remaining type. Aqua's
unbound_args check is no longer marked broken.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds an
Aquajob toci.yml. It runsAqua.test_all(Aqua 0.8) in a temporary environment on Julia1, separate fromPkg.test. Fixes for what it flagged:SparseArrayCompat,hvcat!,BinaryOps.BinaryOpandBinaryOps.fmodwere exported but never defined. They are no longer exported.Libdl,LinearAlgebra,Random,Serialization,SparseArrays,SuiteSparse).Fixed or skipped:
Test.detect_ambiguities).defaultfill(::Type{Union{T, Nothing}}) where T(and theMissingvariant) leftTunbound and returned the typeTitself, e.g.defaultfill(Union{Int, Nothing}) === Int64. The generic method now stripsNothing/Missingand returnszeroof the rest, so it gives0.Locally on nightly, the Aqua command passes (all checks except ambiguities), and so does
Pkg.test().🤖 Generated with Claude Code