Repository navigation
mul! into dense outputs runs in GraphBLAS; fix Matrix(A') - #166
Merged
Merged
Conversation
mul!(C, A::GBArray, B) with dense B and C fell back to LinearAlgebra's generic single-threaded matmul, so Arpack/KrylovKit never used GraphBLAS. The 5-arg mul! now multiplies in GraphBLAS and writes alpha*A*B + beta*C into C. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Matrix(A') threw a MethodError on wait(::Transpose); materialize first. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## v11 #166 +/- ##
==========================================
+ Coverage 67.23% 67.33% +0.10%
==========================================
Files 54 54
Lines 4465 4485 +20
==========================================
+ Hits 3002 3020 +18
- Misses 1463 1465 +2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #125.
mul!(How to enable multithreading? #125):mul!(C, A, B[, α, β])with a GraphBLASA(or its transpose) and denseB/Cfell back to LinearAlgebra's generic single-threaded matmul. So Arpack'seigs, KrylovKit, etc. never used GraphBLAS or its threads, and onlyA * xdid. The new 5-arg methods (which the 3-arg form forwards to) multiply in GraphBLAS viapackand writeα*A*B + β*CintoC. Contiguous views (e.g. Arpack's work-array slices) are wrapped without copying; other strided inputs are copied.GrB_mxm C=A*B, saxpy.Test.detect_ambiguitiescount is unchanged fromv11(192).Matrix(A')/Matrix(transpose(A)): these threwMethodError: wait(::Transpose); the transpose is now materialized first.A'of a complex array conjugates correctly.mul!against SparseArrays for vectors, matrices, an adjoint and views, plusMatrix(A')for a complex matrix.🤖 Generated with Claude Code