Skip to content

Show the fill value when it isn't the default - #165

Merged
ViralBShah merged 1 commit into
v11from
vs/show-fill
Oct 27, 2026
Merged

ViralBShah merged 1 commit into
v11from
vs/show-fill

Conversation

@ViralBShah

Copy link
Copy Markdown
Member

Fixes #104.

show for a GBArray now adds a line after the GraphBLAS header when the fill value differs from the eltype's default:

2x3 GraphBLAS int64_t matrix, bitmap by row
  2 entries, memory: 296 bytes
  fill value:  17

    (1,2)   1
    (2,3)   2
  • Default-fill arrays print exactly as before.
  • The 2-arg show methods now forward to the text/plain one, so print matches display.
  • Three doctests whose arrays use a non-default fill (nothing/missing) gain the new line.
  • Tests are added to the existing gbarray.jl "dense" testset.
  • Pkg.test() and doctest(SuiteSparseGraphBLAS) pass on Julia nightly.

🤖 Generated with Claude Code

When the fill value differs from `defaultfill(storedeltype(A))`, print a
`fill value:` line after the GraphBLAS header. The default case is
unchanged. Doctests whose arrays have a non-default fill are updated.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@codecov

codecov Bot commented Oct 27, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 90.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 66.15%. Comparing base (bf3ffa0) to head (8504ed0).
⚠️ Report is 1 commits behind head on v11.

Files with missing lines Patch % Lines
src/abstractgbarray.jl 90.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              v11     #165      +/-   ##
==========================================
+ Coverage   66.10%   66.15%   +0.05%     
==========================================
  Files          54       54              
  Lines        4449     4456       +7     
==========================================
+ Hits         2941     2948       +7     
  Misses       1508     1508              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ViralBShah
ViralBShah merged commit ced917d into v11 Oct 27, 2026
7 checks passed
@ViralBShah
ViralBShah deleted the vs/show-fill branch October 27, 2026 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fill value not appearing in show

1 participant