Repository navigation
Fix broadcasts, Int32-index and eltype conversion, scalar constructors; constructor docs - #164
Merged
Merged
Conversation
f was only set for ^, so other operators threw UndefVarError, and the scalar fallback passed apply! its arguments in the wrong order. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
GBMatrix/GBVector from a SparseMatrixCSC or SparseVector widen narrower index types and convert values to the target eltype. unsafepack! on such inputs now throws instead of handing GraphBLAS 32-bit indices. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
- GBMatrix/GBVector docstrings: list constructors from dims, dense arrays, SparseMatrixCSC/SparseVector, and COO with `fill`/`combine`. The scalar (iso) COO forms take no `combine`. - Add docstrings for getfill, gbget, gbrandn and list them on the Utilities page; fix the gbset option list rendering. Fixes #101, fixes #103. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
GBVector(I, x, n) referenced an undefined J, and the dims-plus-scalar constructors passed fill positionally. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## v11 #164 +/- ##
==========================================
+ Coverage 66.10% 67.18% +1.07%
==========================================
Files 54 54
Lines 4449 4458 +9
==========================================
+ Hits 2941 2995 +54
+ Misses 1508 1463 -45 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small fixes from triaging the open issues. Fixes #124, fixes #144, fixes #101.
C .= A .op B: in both the matrix and vectorcopyto!,fwas set only for^, so other operators threwUndefVarError: `f`, and the scalar fallback calledapply!(C, f, ...)instead ofapply!(f, C, ...).SparseMatrixCSC{Float64, Int32}#144 non-Int64 indices:GBMatrix/GBVectorfrom aSparseMatrixCSC/SparseVectorwithInt32indices handed GraphBLAS 32-bit index arrays to read as 64-bit. Indices are now widened when copying.unsafepack!can't share such arrays, so it throws anArgumentErrorinstead.GBMatrix{Float32}(S)/GBVector{Float32}(v)for aFloat64sparse input threw aMethodError(already broken onv11). Values are now converted to the target eltype.GBVector(I, x, n)referenced an undefinedJ, andGBVector((3,), 1.0)/GBMatrix((2,2), 1.0)passedfillpositionally.GBMatrix/GBVector/GBMatrixC/Rdocstrings get a proper# Constructorssection listing the forms that actually exist. Docstrings are added forgetfill,gbgetandgbrandn, which are now on the Utilities page.Each fix has a small test in an existing testset.
Pkg.test()is running on nightly; CI will confirm.🤖 Generated with Claude Code