Repository navigation
refactor!: return LABL_PTR attributes as stored; move fillvalue to CDFDatasets - #81
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Beforerr
force-pushed
the
labl-ptr-as-stored
branch
from
October 15, 2026 18:21
d146366 to
2ead7e6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ISTP conventions belong in CDFDatasets, next to FILLVAL/VALIDMIN masking and DEPEND_TIME handling; the format reader returns attributes as stored.
LABL_PTR_iis the label variable's name, no longer resolved to its labels.fillvalue(ISTP recommended FILLVAL per type) moves to CDFDatasets, its only user.labl_ptr.cdffixture and its test move to CDFDatasets.CDF_CHAR→String(feat!: read CHAR variables as String #79) filed under 0.4.0 and the sparse-records fix under 0.4.2, where they shipped.Released CDFDatasets 0.3.5 imports
fillvaluefrom here, so this needs a minor bump (0.5.0), not 0.4.6. Counterpart: JuliaSpacePhysics/CDFDatasets.jl (istp-labl-ptr).