Repository navigation
perf: avoid invalidation-prone calls in read paths - #75
Merged
Merged
Conversation
`pointer` on arrays of non-inferred eltype goes through `cconvert`, which any new
`cconvert(::Type{Ptr{X}}, ::Vector)` method (LibGit2 defines one) invalidates; call
`unsafe_convert` directly. `[v; x]` goes through generic `cat` and `eltype(::AbstractArray)`;
use `push!`. `String(::AbstractString)` is not inferred, which widened the whole
`CDFDataset(filename)` body.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Contributor
Benchmark Results (Julia v1)Time benchmarks
Memory benchmarks
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three small changes so read-path code isn't thrown away when unrelated packages load:
pointeron an array whose eltype isn't inferred goes throughcconvert. Any package that adds acconvert(::Type{Ptr{X}}, ::Vector)method (LibGit2 does, and it's loaded whenever Pkg is) invalidates_byte_swap!,load_attribute_dataandreadblock!. Callingunsafe_convertdirectly skipscconvert.[v; x]goes through genericcat→eltype(::AbstractArray), which some packages invalidate. Replaced withpush!.String(::AbstractString)isn't inferred, which widenedio,bufferand the constructor call inCDFDataset(filename)toAny. Added a::Stringassertion.With these, loading CDAWeb after Pkg leaves no invalidated CommonDataFormat/CDFDatasets CodeInstances (previously several hundred), and first reads of cached data no longer recompile (~0.06–0.09 s each).