Skip to content

refactor: remove unused read! and read functions from CDFDataset - #62

Merged
Beforerr merged 1 commit into
mainfrom
push-pvslqmutwwnz
Aug 30, 2026
Merged

Beforerr merged 1 commit into
mainfrom
push-pvslqmutwwnz

Conversation

@Beforerr

Copy link
Copy Markdown
Member

No description provided.

@codecov

codecov Bot commented Aug 30, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@github-actions

Copy link
Copy Markdown
Contributor

Benchmark Results (Julia v1)

Time benchmarks
main d7ceadb... main / d7ceadb...
elx/full_load 0.0365 ± 0.0022 ms 0.0367 ± 0.0023 ms 0.995 ± 0.087
elx/sum_array 2.68 ± 0.47 μs 2.78 ± 0.5 μs 0.964 ± 0.24
elx/sum_lazy 2.65 ± 1.2 μs 2.59 ± 1.2 μs 1.02 ± 0.66
elx/sum_var_access 3.06 ± 1.1 μs 3.13 ± 0.59 μs 0.978 ± 0.39
elx/var_access 0.32 ± 0.059 μs 0.321 ± 0.011 μs 0.997 ± 0.19
mms/full_load 21.7 ± 2.2 μs 21.4 ± 2.2 μs 1.02 ± 0.15
mms/sum_array 0.0948 ± 0.012 s 0.0952 ± 0.014 s 0.996 ± 0.19
mms/sum_slice 3.55 ± 0.11 ms 3.55 ± 0.12 ms 1 ± 0.045
mms/sum_var_access 3.55 ± 0.1 ms 3.56 ± 0.1 ms 0.999 ± 0.04
mms/var_access 0.11 ± 0.001 μs 0.11 ± 0.01 μs 1 ± 0.091
time_to_load 0.142 ± 0.0047 s 0.144 ± 0.0018 s 0.986 ± 0.035
Memory benchmarks
main d7ceadb... main / d7ceadb...
elx/full_load 0.217 k allocs: 24.8 kB 0.217 k allocs: 24.8 kB 1
elx/sum_array 5 allocs: 27.7 kB 5 allocs: 27.7 kB 1
elx/sum_lazy 5 allocs: 27.7 kB 5 allocs: 27.7 kB 1
elx/sum_var_access 7 allocs: 28 kB 7 allocs: 28 kB 1
elx/var_access 1 allocs: 0.234 kB 1 allocs: 0.234 kB 1
mms/full_load 0.065 k allocs: 6.45 kB 0.065 k allocs: 6.45 kB 1
mms/sum_array 1.03 k allocs: 31.7 MB 1.03 k allocs: 31.7 MB 1
mms/sum_slice 0.064 k allocs: 1.29 MB 0.064 k allocs: 1.29 MB 1
mms/sum_var_access 0.064 k allocs: 1.29 MB 0.064 k allocs: 1.29 MB 1
mms/var_access 1 allocs: 0.219 kB 1 allocs: 0.219 kB 1
time_to_load 0.149 k allocs: 11.2 kB 0.149 k allocs: 11.2 kB 1

@Beforerr
Beforerr merged commit cccc7c9 into main Aug 30, 2026
6 of 7 checks passed
@Beforerr
Beforerr deleted the push-pvslqmutwwnz branch August 30, 2026 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant