Skip to content

Update breakage: use organization-wide workflow - #436

Merged
tmigot merged 2 commits into
JuliaSmoothOptimizers:mainfrom
MaxenceGollier:update-breakage
Jul 31, 2026
Merged

Update breakage: use organization-wide workflow#436
tmigot merged 2 commits into
JuliaSmoothOptimizers:mainfrom
MaxenceGollier:update-breakage

Conversation

@MaxenceGollier

Copy link
Copy Markdown
Contributor

Copilot AI review requested due to automatic review settings July 27, 2026 15:11

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Not ready to approve

The updated .github/workflows/Breakage.yml file appears to have CRLF line endings, which should be normalized to LF to match repository conventions and avoid noisy diffs/tooling issues.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

This review doesn't count toward merge requirements. Sign up for the private preview to control whether Copilot approvals count.

Review details

Suppressed comments (1)

.github/workflows/Breakage.yml:2

  • This file appears to have CRLF line endings (carriage returns show up when viewing it), while the repo generally expects Unix LF line endings; please re-save/normalize this workflow to LF to avoid noisy diffs and potential tooling issues.
name: Breakage

  • Files reviewed: 4/4 changed files
  • Comments generated: 0 new
  • Review effort level: Lite

We're testing this review assessment. Please use 👍 or 👎 to tell us if it's correct.

@codecov

codecov Bot commented Jul 31, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.32%. Comparing base (2ada450) to head (97d7b6b).
⚠️ Report is 64 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #436      +/-   ##
==========================================
- Coverage   99.80%   99.32%   -0.48%     
==========================================
  Files        1084     1139      +55     
  Lines       12319    13548    +1229     
==========================================
+ Hits        12295    13457    +1162     
- Misses         24       91      +67     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment thread .github/workflows/Breakage.yml Outdated
Comment thread .github/workflows/CommentBreakage.yml Outdated
Co-authored-by: Tangi Migot <tangi.migot@gmail.com>

@tmigot tmigot left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tmigot
tmigot merged commit 125a2a1 into JuliaSmoothOptimizers:main Jul 31, 2026
15 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants