Avoid recursive root lowering in make - #67
Open
quinnj wants to merge 1 commit into
Open
Conversation
Lower only non-struct-like root sources before structural builders. This preserves @nonstruct representation mapping while allowing a struct-like lower method to call make for field traversal. Add nested regression coverage and document the root-lowering contract. Fixes #66
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
structlike(style, source)isfalse.@nonstructroot mapping added by Fix root lowering for non-struct mappings #64.lowermethods to callmakefor field traversal without recursion.Root cause
PR #64 made the generic structural
makepath calllowerfor every root source. A struct-likelowermethod implemented withmaketherefore entered a directmake -> lower -> makecycle.The fix keeps root representation lowering for non-struct sources, which is the case required by #29, while traversing ordinary struct roots directly.
applyeachcontinues to lower nested values.Validation
Fixes #66
Co-authored by Codex