Repository navigation
Conversation
Branch on strides[1] == sizeof(R) so LLVM can version loops on the contiguous case. No change to the type parameters.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#715 was closed because the type parameters can't say an array is contiguous. A runtime check turns out to be enough: branching on
strides[1] == sizeof(R)lets LLVM version the loop and vectorise the contiguous case.Float32, Julia 1.13.1, Apple M1, ms:
Arraysum, 1e7 vectorsum, 4-D F-order (4e7)sum,v[::2]Strided and C-order arrays are unchanged within noise.
Broadcasting into an
Array(x .* 2) is still ~3x slower than with anArrayinput. That one is on the Julia side: LLVM won't emit a runtime alias check between theArraystore and thePtrload.The new test uses
_testbuffer, so it doesn't need numpy.