Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
strvalues so Julia code can access UTF-8 bytes without allocating or copying Python data.StaticStringshare correct behaviour.Description
PyString <: AbstractString(stores the underlyingPyobject, aPtr{UInt8}to the UTF-8 data and its bytelength) insrc/API/types.jland implement the wrapper insrc/Wrap/PyString.jl.PyUnicode_AsUTF8AndSizeinsrc/C/pointers.jland use it to constructPyStringwith a pointer+length without copying.src/Utils/Utils.jlby introducingutf8_isvalidandutf8_iterateand adaptStaticStringhelpers to reuse them, and add bounds-checkedcodeunitforPyString.pyconvertrule mappingbuiltins:str→PyStringinsrc/Wrap/Wrap.jlsoPyStringconversion is available while preserving the existing canonicalStringconversion rules; exportPyStringviasrc/API/exports.jl.test/Convert.jlandtest/Utils.jl.Testing
julia --project -e 'using Pkg; Pkg.test()'and the test suite completed with PythonCall tests passing (test summary shows package tests passed while two pre-existing tests were marked broken in the environment).cp pysrc/juliacall/juliapkg-dev.json pysrc/juliacall/juliapkg.json && uv run pytest -s --nbval ./pytestand all Python tests passed (21 passed).julia --project -e 'using Pkg; Pkg.test(coverage=true)'and the coverage run completed; the newPyStringimplementation and the edited UTF-8 utility code have executable lines covered by tests.test/Convert.jlandtest/Utils.jlthat passed during the above runs.Codex Task