Skip to content

Fix 615 fixed waveform - #632

Open
gitpsii wants to merge 4 commits into
JuliaPhysics:mainfrom
gitpsii:fix-615-fixed-waveform
Open

Fix 615 fixed waveform#632
gitpsii wants to merge 4 commits into
JuliaPhysics:mainfrom
gitpsii:fix-615-fixed-waveform

Conversation

@gitpsii

@gitpsii gitpsii commented Sep 2, 2026

Copy link
Copy Markdown

Description

add_baseline_and_extend_tailpreviously returned the waveform signal as a regularVector`, even though the waveform length is required to remain fixed for DAQ waveform processing.

This change wraps the allocated signal in a SizedVector with total_waveform_length as its static size.

Testing

Added tests to verify that the returned signal is a SizedVector and has the expected length.

Fixes #615

@fhagemann

Copy link
Copy Markdown
Collaborator

Thanks for the contribution:
I’ll leave the decision to @oschulz, who might have some opinion about using ArraysOfArrays here.

@fhagemann
fhagemann requested a review from oschulz September 2, 2026 15:33
@oschulz

oschulz commented Sep 3, 2026

Copy link
Copy Markdown
Member

total_waveform_length is not known at compile time and can be quite large, I don't think we want to type-parameterize based on it.

@gitpsii

gitpsii commented Sep 3, 2026

Copy link
Copy Markdown
Author

Thanks, that makes sense. I see that SizedVector{total_waveform_length would type-parameterize on a runtime value and could be problematic for large waveform lengths. What fixed-length array type/approach would you recommend for this function?

@oschulz

oschulz commented Sep 3, 2026

Copy link
Copy Markdown
Member

We could look into using FixedSizeArrays.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Return fixed length array with add_baseline_and_extend_tail

3 participants