Fix 615 fixed waveform - #632
Open
gitpsii wants to merge 4 commits into
Open
Conversation
Collaborator
|
Thanks for the contribution: |
Member
|
|
Author
|
Thanks, that makes sense. I see that SizedVector{total_waveform_length would type-parameterize on a runtime value and could be problematic for large waveform lengths. What fixed-length array type/approach would you recommend for this function? |
Member
|
We could look into using FixedSizeArrays. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
add_baseline_and_extend_tail
previously returned the waveform signal as a regularVector`, even though the waveform length is required to remain fixed for DAQ waveform processing.This change wraps the allocated signal in a SizedVector with total_waveform_length as its static size.
Testing
Added tests to verify that the returned signal is a SizedVector and has the expected length.
Fixes #615