Repository navigation
Fix rowsupport/colsupport over ranges for rectangular block-banded ma… - #253
Merged
Merged
Conversation
…trices For a block row lying entirely outside the band (e.g. trailing block rows of a tall matrix), blockrowstop is the `last` of an empty BlockRange, which can lie past the final block column. blockbanded_rowstop then returned the sentinel 0, breaking the monotonicity assumed by the range method `blockbanded_rowsupport(A, j) = rowstart(A, minimum(j)):rowstop(A, maximum(j))`, so e.g. rowsupport(A, axes(A,1)) was empty. ArrayLayouts' default_blasmul! uses this to bound the loop, so x' * A returned zeros for rectangular BlockBandedMatrix/BandedBlockBandedMatrix (and likewise A * B for wide A via colsupport). Clamp the stop to the last row/column instead. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #253 +/- ##
==========================================
- Coverage 90.79% 90.67% -0.13%
==========================================
Files 11 11
Lines 1173 1179 +6
==========================================
+ Hits 1065 1069 +4
- Misses 108 110 +2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…trices
For a block row lying entirely outside the band (e.g. trailing block rows of a tall matrix), blockrowstop is the
lastof an empty BlockRange, which can lie past the final block column. blockbanded_rowstop then returned the sentinel 0, breaking the monotonicity assumed by the range methodblockbanded_rowsupport(A, j) = rowstart(A, minimum(j)):rowstop(A, maximum(j)), so e.g. rowsupport(A, axes(A,1)) was empty. ArrayLayouts' default_blasmul! uses this to bound the loop, so x' * A returned zeros for rectangular BlockBandedMatrix/BandedBlockBandedMatrix (and likewise A * B for wide A via colsupport). Clamp the stop to the last row/column instead.