Repository navigation
Fix conjlayout of the block-banded layouts - #249
Merged
Merged
Conversation
The conjlayout rules passed the layout of the data as a type rather than an
instance, so the inner conjlayout call always fell back to UnknownLayout. The
adjoint of a complex BandedBlockBandedMatrix therefore had the layout
BandedBlockBandedRows{UnknownLayout} instead of describing its conjugated data.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #249 +/- ##
=======================================
Coverage 90.45% 90.45%
=======================================
Files 11 11
Lines 1142 1142
=======================================
Hits 1033 1033
Misses 109 109 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
The body line of the two-line size definitions was inconsistently instrumented by coverage and reported as missed, failing codecov/project. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
conjlayoutrules for the block-banded layouts passed the layout of the data as a type rather than an instance, so the inner call always fell back toUnknownLayout(). The adjoint of a complex matrix therefore lost the description of its data:Real eltypes are unaffected, since
conjlayout(::Type{<:Real}, M) = M. Downstream this also lets a lazy layout survive an adjoint:BandedBlockBandedColumns{LazyLayout}now givesBandedBlockBandedRows{LazyLayout}rather thanBandedBlockBandedRows{UnknownLayout}.Tests are added for both the banded-block-banded and block-banded cases, and the patch version is bumped.
🤖 Generated with Claude Code