Repository navigation
Avoid reshape when materialising DualLayout views of matrices - #294
Open
dlfivefifty wants to merge 1 commit into
Open
dlfivefifty wants to merge 1 commit into
dlfivefifty wants to merge 1 commit into
Conversation
`_dual_adjoint`/`_dual_transpose` assumed the parent of a `DualLayout` view is an adjoint/transpose of a vector. When it is a 1×n matrix with `DualLayout` (e.g. a `BlockedMatrix` wrapping an adjoint vector), the adjoint is an n×1 matrix and linear indexing into it reshapes, which fails for infinite arrays. Take a column view instead. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
_dual_adjoint/_dual_transposeassumed the parent of aDualLayoutview is an adjoint/transpose of a vector. When it is a 1×n matrix withDualLayout(e.g. aBlockedMatrixwrapping an adjoint vector), the adjoint is an n×1 matrix and linear indexing into it reshapes, which fails for infinite arrays. Take a column view instead.