Repository navigation
Fix the types of NSError.userInfo and localizedRecoveryOptions - #90
Merged
Merged
Conversation
The property converted to `Dict{NSString,Object}`, but `Object` is abstract
and can't wrap a pointer, so reading the user info of any error that has
some threw a `MethodError`. Convert the values to `NSObject` instead.
It is an array of strings, not a string. Treating it as an `NSString` made `showerror` send `UTF8String` to an `NSArray`, which aborts the process with an uncaught Objective-C exception for any error that has recovery options.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two
NSErrorproperties had the wrong types:userInfoconverted toDict{NSString,Object}, butObjectis abstract and can't wrap a pointer. Reading the user info of any error that has some threwMethodError: no method matching Object(::id{Object}). The values are nowNSObjects.localizedRecoveryOptionsis anNSArrayof strings, not anNSString.showerrorthen sentUTF8Stringto the array, which aborts the process (-[__NSArrayI UTF8String]: unrecognized selector) whenever an error with recovery options is displayed. It's now aVector{NSString}.Found while looking at the errors Metal returns when pipeline creation fails (JuliaGPU/Metal.jl#1074). Tests for both properties are in the
NSErrortestset.