Add KernelAbstractions device selection interface - #483
Merged
Merged
Conversation
christiangnrd
marked this pull request as ready for review
September 14, 2026 12:39
christiangnrd
force-pushed
the
kadev
branch
2 times, most recently
from
September 14, 2026 18:26
f088dfd to
db3f849
Compare
christiangnrd
added this pull request to stack #486
September 14, 2026 18:34
christiangnrd
force-pushed
the
kadev
branch
from
September 14, 2026 22:13
db3f849 to
dedc1e5
Compare
christiangnrd
force-pushed
the
kadev
branch
from
September 15, 2026 01:23
dedc1e5 to
a583a6c
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #483 +/- ##
==========================================
- Coverage 84.45% 84.26% -0.19%
==========================================
Files 14 14
Lines 1087 1106 +19
==========================================
+ Hits 918 932 +14
- Misses 169 174 +5 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
vchuravy
reviewed
Sep 15, 2026
christiangnrd
force-pushed
the
kadev
branch
2 times, most recently
from
September 15, 2026 13:48
8f20f85 to
1b57b9e
Compare
christiangnrd
force-pushed
the
kadev
branch
from
September 15, 2026 13:50
1b57b9e to
66d0d4e
Compare
vchuravy
approved these changes
Sep 15, 2026
vchuravy
reviewed
Sep 15, 2026
christiangnrd
force-pushed
the
kadev
branch
from
September 15, 2026 15:29
2f75c0f to
a3e3969
Compare
vchuravy
reviewed
Sep 16, 2026
| end | ||
|
|
||
| function KA.allocate(::OpenCLBackend, ::Type{T}, dims::Tuple; unified::Bool = false) where T | ||
| function check_platform(b::OpenCLBackend) |
Member
There was a problem hiding this comment.
You likely want to outline the warning and inline the check.
Member
Author
There was a problem hiding this comment.
If 7f6383e looks good to you, I’ll merge once tests pass
christiangnrd
force-pushed
the
kadev
branch
2 times, most recently
from
September 17, 2026 22:37
7f6383e to
54ecaf6
Compare
christiangnrd
force-pushed
the
kadev
branch
from
September 17, 2026 22:38
54ecaf6 to
5350e44
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The KA 0.10 docs (rightfully) make this a mandatory implementation if a backend supports multiple devices.
This adds a
platformfield toOpenCLBackend.