[KernelInterface 0.2] Take an element type in the indexing queries - #754
Open
christiangnrd wants to merge 4 commits into
Open
[KernelInterface 0.2] Take an element type in the indexing queries#754christiangnrd wants to merge 4 commits into
christiangnrd wants to merge 4 commits into
Conversation
`get_global_size`, `get_global_id`, `get_local_size`, `get_local_id`,
`get_num_groups` and `get_group_id` now accept an optional element type
and return a `@NamedTuple{x::T, y::T, z::T}`. The zero-argument form
forwards to `Int`; backends implement only the typed form.
The POCL backend converts with `T(...)` rather than `% T`: with a plain
truncation LLVM folds the `<3 x i64>` builtin load into a `<6 x i32>`
load, which SPIR-V rejects.
Adds typed return-type and value tests to the interface testsuite and
updates the standalone stub tests and documentation.
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Member
Author
|
Added to milestone because we should make a decision before 0.10, not because this needs to be merged |
vchuravy
reviewed
Sep 8, 2026
vchuravy
approved these changes
Sep 8, 2026
christiangnrd
changed the title
christiangnrd
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ignore backend tests
This is something that people seem to really want.
Yet undocumented caveat that the eltype should be the same in every query for a kernel.
Is this a decent interface?