Repository navigation
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #869 +/- ##
==========================================
- Coverage 91.17% 91.10% -0.08%
==========================================
Files 11 11
Lines 1077 1079 +2
==========================================
+ Hits 982 983 +1
- Misses 95 96 +1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #868.
min/maxonDualwere generated from DiffRules. Those rules choose the partials by value only, so on a tie in value the result depended on the argument order rather than onisless, which breaks ties on the partials since #695:No DiffRules rule can express this tie-breaking, since a rule only sees the values. So this PR stops generating
min/maxfrom DiffRules and defines them in terms ofisless. Likemin/maxon floats, they propagate NaN values. MixedDual/Realarguments are promoted by Base'smin(::Real, ::Real).🤖 Generated with Claude Code