Repository navigation
Apply array shape rules in Diagonal/Bidiagonal/SymTridiagonal projectors - #720
Merged
Merged
Conversation
The projectors for Diagonal, Bidiagonal and SymTridiagonal now use the same
shape rules as ProjectTo{AbstractArray}, via a shared _projection_reshape helper:
- gradients with trailing singleton dimensions, e.g. dx = ones(3, 3, 1), are
accepted (previously a MethodError);
- wrongly sized matrices throw a DimensionMismatch (previously Diagonal silently
took the diagonal of e.g. 3×4 and 4×3 matrices, and Bidiagonal of 4×3 ones).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #720 +/- ##
==========================================
+ Coverage 93.41% 93.47% +0.05%
==========================================
Files 15 15
Lines 1002 1011 +9
==========================================
+ Hits 936 945 +9
Misses 66 66 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
ProjectTomethods forDiagonal,BidiagonalandSymTridiagonalnow apply the same shape rules asProjectTo{AbstractArray}, through a shared helper_projection_reshapethat is moved out unchanged from theAbstractArraymethod:dx = ones(3, 3, 1), are now accepted. They used to throw aMethodError, unlike theSymmetric/Hermitian/triangular/Tridiagonalprojectors.DimensionMismatch. Before,Diagonalsilently took the diagonal of 3×4 and 4×3 matrices, andBidiagonalof 4×3 ones.Matrices of the right size take the existing
axes(dx) === axes(x)fast path, so neither speed nor allocations change.This is needed for JuliaDiff/ChainRules.jl#783, where
rrule(+, ::Matrix, ::Diagonal, ::Array{3})projects a 3×3×1 cotangent onto aDiagonal.Bumps the version to 1.26.5.
🤖 Generated with Claude Code