Skip to content

Make sum of bool arrays nondiffernetiable #267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
devmotion merged 5 commits into from
Oct 26, 2026
+5 −1
Merged

Make sum of bool arrays nondiffernetiable #267

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
f6c990f
Make sum of bool arrays nondiffernetiable
oxinabox Sep 16, 2020
3d5e744
Apply suggestions from code review
oxinabox Sep 29, 2020
b98f537
Merge branch 'main' into ox/ndsumbool
devmotion Oct 26, 2026
d1bbb3d
Fix format
devmotion Oct 26, 2026
8d361d5
Bump version from 1.74.4 to 1.74.5
devmotion Oct 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Project.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
name = "ChainRules"
uuid = "082447d4-558c-5d27-93f4-14fc19e9eca2"
version = "1.74.4"
version = "1.74.5"

[deps]
Adapt = "79e6a3ab-5dfb-504d-930d-738a2a938a0e"
Expand Down
1 change: 1 addition & 0 deletions src/rulesets/Base/nondiff.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,6 +81,7 @@
@non_differentiable sum(::AbstractArray{Bool})
@non_differentiable sum(::Any, ::AbstractArray{Bool})
@non_differentiable sum(::typeof(abs2), ::AbstractArray{Bool}) # avoids an ambiguity
@non_differentiable sum(::NTuple{<:Any,Bool})
@non_differentiable vcat(::AbstractArray{Bool}...)
@non_differentiable vec(::AbstractArray{Bool})
@non_differentiable Vector(::AbstractArray{Bool})
Expand Down
3 changes: 3 additions & 0 deletions test/rulesets/Base/mapreduce.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,9 @@ struct SumRuleConfig <: RuleConfig{Union{HasReverseMode}} end
test_rrule(sum, Tuple(rand(5)))
test_rrule(sum, (1.2, 3.4 + 5im))
test_rrule(sum, (rand(2)', rand(1,2)))

# Boolean -- via @non_differentiable
test_rrule(sum, (true, false, true))
end
@testset "sum(x; dims=$dims)" for dims in (:, 2, (1,3))
# Forward
Expand Down
Loading