Repository navigation
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1166 +/- ##
=======================================
Coverage 95.75% 95.75%
=======================================
Files 9 9
Lines 5489 5489
=======================================
Hits 5256 5256
Misses 233 233 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
[Reviewed by AI] Scoped review of the example at Both zip-writing variants round-trip correctly through the proposed Current main already closes the archive file through |
Adapt nhz2's buffered ZIP example to the current documentation, retaining the byte-based entry reader. Describe both archive and entry buffering and link the original file-backed alternative for larger archives. AI disclosure: This work was prepared with assistance from OpenAI Codex. Co-authored-by: nhz2 <nhz2@cornell.edu>
8cf0b96 to
b2e1330
Compare
As noted by @JakeZw in #1158 (comment)
The zip file example was not properly closing things.
And as noted in JuliaIO/ZipArchives.jl#90, using mmap might not always be ideal.
This PR changes the example to avoid using streaming or mmap and instead buffers everything in memory to keep things simple.
I can give a more complete example based on the code in https://github.com/JuliaIO/ZipArchives.jl/blob/v2.5.1/test/test_file-array.jl
But this can get more complicated.